Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement typing with extended character support for more languages #6207

Open
1 task done
Branikolog opened this issue Nov 18, 2022 · 4 comments
Open
1 task done
Labels
improvement New feature, request or improvement translation Things related to languages and translations

Comments

@Branikolog
Copy link
Collaborator

Preliminary checks

Describe the problem requiring a solution

image
Only English is used while creating player's name.

Describe the possible solution

Since fheroes2 supports multiple languages, it would be nice, if players could type their names using the language supported by the engine.

Additional info

No response

@Branikolog Branikolog added improvement New feature, request or improvement translation Things related to languages and translations labels Nov 18, 2022
@Branikolog Branikolog added this to the Beyond 1.0 milestone Nov 18, 2022
@zenseii
Copy link
Collaborator

zenseii commented Nov 18, 2022

Just adding that this will probably only be possible once we add UTF-8 encoding support. There should be an issue for that.

@undef21
Copy link
Contributor

undef21 commented Nov 19, 2022

I think sphinx's riddle dialog has the same issue. Some localized maps can have non-ASCII answers.
AFAIK windows versions of OG have support of national encodings but dos versions (e.g. French) haven't. In dos versions the game filtered user input and allowed only ASCII chars.

@zenseii
Copy link
Collaborator

zenseii commented Nov 22, 2022

Basically this is relevant for any place where the user is asked to type, so even writing save game names.

I'll change the issue title to reflect this.

@zenseii zenseii changed the title Typing player name with supported languages Implement typing with extended character support for more languages Nov 22, 2022
@667bdrm
Copy link

667bdrm commented Feb 19, 2023

On this map sphinx dialog allow enter only digits. English or Russian letters typing does not change the field. Looks like this map file use Windows 1251 charset for text.

Ubuntu 20.04.5 LTS

image

Горы Альтерак.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement translation Things related to languages and translations
Projects
None yet
Development

No branches or pull requests

4 participants