Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make idempotent [install & adjust ImageMagick for Calibre-Web thumbnail previews of PDFs] #1567

Merged
merged 4 commits into from
Mar 13, 2019
Merged

Make idempotent [install & adjust ImageMagick for Calibre-Web thumbnail previews of PDFs] #1567

merged 4 commits into from
Mar 13, 2019

Conversation

tim-moody
Copy link
Contributor

which I now can't merge

@holta holta added this to the 7.0 milestone Mar 13, 2019
@holta
Copy link
Member

holta commented Mar 13, 2019 •
edited

Refs: #1530 #1555 PRs #1565 #1566

@tim-moody
Copy link
Contributor Author

works on ub vm
not tried on rpi

@holta holta changed the title make idempotent make idempotent [install ImageMagick for Calibre-Web thumbnail previews of PDFs] Mar 13, 2019
@holta
Copy link
Member

holta commented Mar 13, 2019

Thanks to @tim-moody who tested this on RPi.

Clarifs:

  1. The config file /etc/ImageMagick-6/policy.xml is being left alone on OS's not yet affected by ImageMagick's new security restriction, e.g. Raspbian for now.
  2. If a line therein is found to contain:
<policy domain="coder" rights="none" pattern="PDF" />

...that line will be replaced by:

  <policy domain="coder" rights="read" pattern="PDF" />

@holta holta merged commit a0c8314 into iiab:master Mar 13, 2019
This was referenced Mar 13, 2019
Closed
Closed
@holta holta changed the title make idempotent [install ImageMagick for Calibre-Web thumbnail previews of PDFs] Make idempotent [install & adjust ImageMagick for Calibre-Web thumbnail previews of PDFs] Mar 14, 2019
@tim-moody tim-moody deleted the cal-web branch September 12, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tim-moody @holta