Bluetooth PAN and Terminal servers #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
passed smoke test on non-rpi |
|
passed smoke test on rpi |
|
To ensure updates don't undue the change please copy the Bluetooth service file to /etc/systemd/system/ and edit that copy. |
|
good point. thanks for catching it. |
|
What a pain to have to add "| bool" to all our flags. Some are missing in this PR |
|
It's my impression that when there is a Boolean operation the cast is not required. so when: is_rpi and bluetooth_install but when: is_rpi |bool |
|
good to know, thanks
…On Wed, Jun 12, 2019 at 11:30 AM Tim Moody ***@***.***> wrote:
It's my impression that when there is a Boolean operation the cast is not
required. so when: is_rpi and bluetooth_install but when: is_rpi |bool
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1716?email_source=notifications&email_token=AAOTQHFYFJHXPCNAT6QL2XLP2E6D5A5CNFSM4HSC2FZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXRMBNQ#issuecomment-501399734>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOTQHDQNVW6KL4IIPVS66DP2E6D5ANCNFSM4HSC2FZA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.