Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't enable Apache site if native nginx support exists #2141

Closed
wants to merge 3 commits into from

Conversation

jvonau
Copy link
Contributor

@jvonau jvonau commented Jan 13, 2020

without proxy_pass to Apache

@jvonau jvonau force-pushed the restarts branch 3 times, most recently from 15f2fc2 to 7f954fa Compare January 13, 2020 09:02
@holta holta added this to the 7.1 milestone Jan 13, 2020
@jvonau jvonau mentioned this pull request Jan 13, 2020
@jvonau
Copy link
Contributor Author

jvonau commented Jan 13, 2020

supersedes #2102 with #2134 #2143

@holta
Copy link
Member

holta commented Jan 14, 2020

@jvonau's listing @ #2078 (comment) also very helpful to understanding & evolving https://github.com/iiab/iiab/blob/master/roles/nginx/README.md over the coming days/weeks!

@jvonau
Copy link
Contributor Author

jvonau commented Jan 18, 2020

So why can't I use the web interface to resolve conflicts like I was able to do in other PRs?

@holta
Copy link
Member

holta commented Jan 18, 2020

So why can't I use the web interface to resolve conflicts like I was able to do in other PRs?

It's happened to me too, for certain very simple merge conflicts. Very annoying.

@jvonau
Copy link
Contributor Author

jvonau commented Jan 20, 2020

I see why, files were renamed in 2166.

@jvonau
Copy link
Contributor Author

jvonau commented Jan 24, 2020

superseded by #2189

@jvonau jvonau closed this Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants