Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change resize service to use growpart, which must be installed for raspios #2465

Merged
merged 2 commits into from
Jul 10, 2020

Conversation

tim-moody
Copy link
Contributor

parted no longer works on ub 20

@holta holta added this to the 7.2 milestone Jul 9, 2020
@holta
Copy link
Member

holta commented Jul 9, 2020

@tim-moody does tune2fs -m 1 /dev/mmcblk0p2 (at https://github.com/iiab/iiab-factory/blob/master/iiab#L175-L180) remain ok on RaspiOS and Ubuntu-on-RPi both?

@tim-moody
Copy link
Contributor Author

I have no reason to think otherwise.

@holta
Copy link
Member

holta commented Jul 10, 2020

Is this reasonably safe to merge?

@tim-moody
Copy link
Contributor Author

just testing

@tim-moody
Copy link
Contributor Author

passed smoke test

@holta
Copy link
Member

holta commented Jul 10, 2020

passed smoke test

On which OS?

@tim-moody
Copy link
Contributor Author

passed functional test on ub20 (and seems faster)

On which OS?

should be irrelevant as long as rpi

@tim-moody
Copy link
Contributor Author

passed smoke and functional tests on raspios

@holta
Copy link
Member

holta commented Sep 15, 2020

@tim-moody clarifies (#2517 (comment)) that this PR apparently introduced an upstream bug (https://bugs.launchpad.net/cloud-utils/+bug/1881014) causing serious IIAB image corruption (boots fail) when growpart fails to interpret the output of uname -r ?

This should probably be documented in our IIAB 7.2 Known Issues (until this is hopefully solved upstream?)

@holta
Copy link
Member

holta commented Sep 15, 2020

Related discussion of possible mitigation (not quite bug fix) is ongoing here:

PR #2522 "strict ordering [fix for #2517 boot failures on Zero W re: growpart ? Partition fsck / resizing questions]"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants