osm_vector_maps was repeatedly failing to install, so use 'timeout: "{{ download_timeout }}"' with get_url (in 10 roles!) [& change IIAB's 'download_timeout: 200' to 100 sec] #3083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIAB's OpenStreetMap installer (osm-vector-maps/tasks/install.yml) is very fragile when GitHub and/or your ISP (Internet) is overwhelmed.
As I discovered repeatedly yesterday, the problem is especially acute when trying to install osm-vector-maps as a result of this role downloading so many different files.
This PR fixes the problem, by avoiding Ansible's default timeout for
get_url:
of 10 seconds, and using 100 seconds instead.This PR also establishes
'timeout: "{{ download_timeout }}"'
essentially across the board, for almost all of repo iiab/iiab's ~50 uses of get_url, as this was missing from almost 10 roles.The exception (where we do not want to use
timeout: "{{ download_timeout }}"
) is:iiab/roles/0-init/tasks/network.yml
Lines 22 to 31 in 2634fa2
Note that the Internet is comparatively more stable in major cities around the world in 2021, as compared to 5 years ago, so this PR also lowers
download_timeout: 200
todownload_timeout: 100
(seconds), to try to avoid pointlessly frustrating delays.In future years we (might!) possibly want to further lower this IIAB setting (in default_vars.yml etc) from 100 seconds, down to 60 seconds or so?
Tangentially related: