New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default for use in netplan.yml and wording #3319
Conversation
For the record the reason the 2 conditional were 2 parts in the past within detected_network.yml was to tell which one applied while debugging. |
Is this line no longer sufficient or no longer useful? iiab/roles/network/defaults/main.yml Line 86 in b735672
Related: |
Not sufficient when called via 1-Prep and the service is not enabled. |
The only fix noted when clean installing on Ubuntu desktops, in this case Mate, other Ubuntu variants should be the same as they all use NetworkManager as the backend for use with netplan and ship with systemd-networkd present but disabled. |
For the record |
Note: As of today 92 packages should be upgraded post install on the upstream Mate-arm64 image while my images would have these updates baked into the image. |
Is this PR tested + safe? |
Just build image with this commit in place.. or the builder would puke.. |
If that is the only change ship it.. |
Fixes bug:
Default to False or perhaps move the
when: ansible_local.local_facts.systemd_networkd == "enabled" or ansible_local.local_facts.systemd_networkd == "enabled-runtime"
to replacewhen: systemd_networkd_active
Description of changes proposed in this pull request:
Smoke-tested on which OS or OS's:
Mention a team member @username e.g. to help with code review: