Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default for use in netplan.yml and wording #3319

Merged
merged 5 commits into from Jul 23, 2022

Conversation

jvonau
Copy link
Contributor

@jvonau jvonau commented Jul 23, 2022

Fixes bug:

Default to False or perhaps move the when: ansible_local.local_facts.systemd_networkd == "enabled" or ansible_local.local_facts.systemd_networkd == "enabled-runtime" to replace when: systemd_networkd_active

Description of changes proposed in this pull request:

Smoke-tested on which OS or OS's:

Mention a team member @username e.g. to help with code review:

@jvonau
Copy link
Contributor Author

jvonau commented Jul 23, 2022

For the record the reason the 2 conditional were 2 parts in the past within detected_network.yml was to tell which one applied while debugging.

@holta
Copy link
Member

holta commented Jul 23, 2022

Is this line no longer sufficient or no longer useful?

systemd_networkd_active: False

Related:

@jvonau jvonau changed the title default Set default for use in netplan.yml and wording Jul 23, 2022
@jvonau
Copy link
Contributor Author

jvonau commented Jul 23, 2022

Not sufficient when called via 1-Prep and the service is not enabled.

@jvonau
Copy link
Contributor Author

jvonau commented Jul 23, 2022

The only fix noted when clean installing on Ubuntu desktops, in this case Mate, other Ubuntu variants should be the same as they all use NetworkManager as the backend for use with netplan and ship with systemd-networkd present but disabled.

@holta holta added this to the 8.0 milestone Jul 23, 2022
@holta holta added the bug label Jul 23, 2022
@jvonau
Copy link
Contributor Author

jvonau commented Jul 23, 2022

For the record ./runrole --reinstall network would not be enough to uncover this one as we enable and use systemd-networkd for br0 but out of the box all desktops would have this service disabled, thus I found this one building new images for #3303

@jvonau
Copy link
Contributor Author

jvonau commented Jul 23, 2022

Note: As of today 92 packages should be upgraded post install on the upstream Mate-arm64 image while my images would have these updates baked into the image.

@holta
Copy link
Member

holta commented Jul 23, 2022

Is this PR tested + safe?

@jvonau
Copy link
Contributor Author

jvonau commented Jul 23, 2022

Just build image with this commit in place.. or the builder would puke..

@jvonau
Copy link
Contributor Author

jvonau commented Jul 23, 2022

If that is the only change ship it..

@holta holta merged commit 4307f65 into iiab:master Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants