Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detected_network.yml: Disallow multi-line var second_gateway_found ~= exclude_devices (to avoid polluting /etc/iiab/iiab.ini) #3334

Merged
merged 3 commits into from Aug 4, 2022

Conversation

holta
Copy link
Member

@holta holta commented Aug 4, 2022

To keep /etc/iiab/iiab.ini from being polluted with multi-line variable artifacts like the following...

exclude_devices = none
wlp12s0
num_lan_interfaces = 1

...which prevented @EMG70 from running Admin Console earlier today, when he had 3 gateways (no doubt without realizing it) apparently including (1) his laptop's Ethernet (2) his laptop's internal WiFi (3) a USB WiFi dongle. As confirmed by his Dell laptop's iiab-network.log (Line 9374) that is broken into 2 lines here:

2022-08-01 07:22:05,597 p=3352 u=root n=ansible | TASK [network : Set exclude_devices if default gateway has been detected for wlx1ca7705e063c
wlp12s0] ***

So this PR should help intercept problematic network attempts of this sort, e.g. when IIAB is being pushed too far into complex networking scenarios we're not ready to support at this time!

A bit of background:

@holta holta added this to the 8.0 milestone Aug 4, 2022
@holta
Copy link
Member Author

holta commented Aug 4, 2022

It took hours to get to the bottom of this issue (thank you to @shanti-bhardwa, @jvonau and @tim-moody) but now the root cause is understood.

So this PR should reduce the agony, when this happens to the next person — who inevitably likewise adds a USB WiFi dongle(s) when their laptop already has an Ethernet and WiFi connection to their home router etc — and then runs iiab-network

@holta holta changed the title detected_network.yml: Disallow multi-line var second_gateway_found ~= exclude_devices detected_network.yml: Disallow multi-line var second_gateway_found ~= exclude_devices (to avoid polluting /etc/iiab/iiab.ini) Aug 4, 2022
@holta
Copy link
Member Author

holta commented Aug 4, 2022

Good enough.

Can be further refined later if @jvonau / others want to refactor / enhance.

@holta holta merged commit 45bd088 into iiab:master Aug 4, 2022
@holta holta mentioned this pull request Aug 4, 2022
@jvonau
Copy link
Contributor

jvonau commented Aug 4, 2022

Adding a usb-dongle is not the problem, using the same dongle at an upstream connection before running iiab-network is the problem as there would be not a device available to assign to for use with hostapd. This leave the new device unused within the GUI needs to be better documented, for better user education.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants