Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cwivagg timezone patch [Matomo] #3354

Merged
merged 4 commits into from
Aug 31, 2022
Merged

Conversation

cwivagg
Copy link
Contributor

@cwivagg cwivagg commented Aug 31, 2022

Fixes bug: Matomo install failure blocking IIAB 1/2/3 installs on Ubuntu 22 VirtualBoxes

Description of changes proposed in this pull request:

  1. Fixes the bug by providing a fallback timezone, which is the original source of the problem.
  2. Also fixes a problem where Matomo is having trouble accessing its own directory. I think this may be related to the Ansible updates after my commit and will root cause it at the same time as I am retroing how the above bug got past my testing.

Smoke-tested on which OS or OS's:

Ubuntu 22 VirtualBox and Multipass Ubuntu 22. Per offline conversation with @holta , as long as Ansible is consistent across systems, this change should be fine. We capture both branches of the forking logic with these two systems (VirtualBox for the status code 200 case and Multipass for the status code 302 case).

Mention a team member @username e.g. to help with code review:

@holta

Additionally, temporarily switch apache_user to www-data to unblock access to Matomo. Will debug later.
@holta
Copy link
Member

holta commented Aug 31, 2022

  1. When should this be merged? If it's smoke-tested & you trust it, that's sufficient!

  2. Out of curiosity why is "{{ apache_user }}" hard-coded to www-data ?

Related:

@holta holta added the bug label Aug 31, 2022
@holta holta added this to the 8.0 milestone Aug 31, 2022
@holta holta changed the title Cwivagg timezone patch Cwivagg timezone patch [Matomo] Aug 31, 2022
@cwivagg
Copy link
Contributor Author

cwivagg commented Aug 31, 2022

I've removed the www-data change. There's something weird going on with the directory ownership, but I'll need to look at this a little bit more. It's not related to the main bug fix, and I shouldn't have included it.

@cwivagg cwivagg marked this pull request as ready for review August 31, 2022 13:16
@holta holta merged commit 9a78a0a into iiab:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants