Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MineTest to only use package on all platforms #3426

Merged
merged 5 commits into from Nov 18, 2022

Conversation

tim-moody
Copy link
Contributor

Not yet tested

@holta holta added this to the 8.0 milestone Nov 16, 2022
@holta
Copy link
Member

holta commented Nov 17, 2022

  1. Can these 9 final lines be removed from vars/raspbian-11.yml if possible?

    
    # Minetest for RPi
    minetest_server_bin: /library/games/minetest/bin/minetestserver
    minetest_working_dir: /library/games/minetest
    minetest_game_dir: /library/games/minetest/games/minetest_game
    minetest_rpi_src_tar: minetest.5.1.1.tar.gz
    #minetest_rpi_src_url: "https://www.nathansalapat.com/downloads/{{ minetest_rpi_src_tar }}"
    minetest_rpi_src_url: "{{ iiab_download_url }}/{{ minetest_rpi_src_tar }}"
    minetest_rpi_src_untarred: Minetest
    
  2. Where should var minetest_game_dir be set, prior to running minetest_install_mods.yml ? (Or is this variable possibly less needed than in the past ?)

  3. Both unused templates should be suffixed with.unused or similar, to make that clear:

    • roles/minetest/templates/minetest.conf.j2
    • roles/minetest/templates/minetest-server.service.j2
  4. This default_vars.yml line needs to be revised:

    minetest_default_game: carbone-ng    # only carbone-ng and minetest are supported
    
  5. Is overriding this default_vars.yml line something that we still want to promote?

    minetest_flat_world: False
    
  6. roles/README.rst needs a few quick revisions, just to summarize the above.

@tim-moody
Copy link
Contributor Author

tim-moody commented Nov 17, 2022

1 don't recall why all this is here but shouldn't be needed now.
2. & 4 think my default vars was not committed
5 was a TK request
6 in due time as indicated

minetest_default_game: carbone-ng # only carbone-ng and minetest are supported
# minetest_default_game: carbone-ng # carbone-ng is not longer compatible so not supported
minetest_default_game: minetest
# minetest_default_game: dreambuilder - after 5.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# minetest_default_game: dreambuilder - after 5.6
# minetest_default_game: dreambuilder - requires minetest-server >= 5.6

@tim-moody tim-moody merged commit fcc8bcc into iiab:master Nov 18, 2022
@holta
Copy link
Member

holta commented Nov 18, 2022

FYI Debian 12 (Bookworm) and Ubuntu 23.04 (Lunar Lobster) both today offer minetest-server 5.6.1 via apt.

So those wanting https://github.com/mt-mods/dreambuilder_game (which apparently requires minetest-server >= 5.6) should benefit in 2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants