Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put Kiwix var {{ systemctl_program }} to rest — simple is almost always better #3446

Merged
merged 3 commits into from
Dec 27, 2022

Conversation

holta
Copy link
Member

@holta holta commented Dec 26, 2022

Unclear that systemctl really needs a full path but it can't hurt.

Tested on Ubuntu 23.04's latest daily, with this PR using canonical path /usr/bin/systemctl to be consistent with command-line usage.

Building on:

@holta holta added this to the 8.0 milestone Dec 26, 2022
@holta holta changed the title Put var {{ systemctl_program }} to rest — simple is almost always better Put Kiwix var {{ systemctl_program }} to rest — simple is almost always better Dec 26, 2022
@jvonau
Copy link
Contributor

jvonau commented Dec 26, 2022

Or just alter the crontab stanza to actually use systemctl_program, touches one file instead of 3 files. Might also want to update to the cron ansble plugin in place of lineinfile like matomo uses.

@jvonau
Copy link
Contributor

jvonau commented Dec 27, 2022

Guess I should of asked if the 4am restart of kiwix is even still required as this was originally a cheap workaround to keep kiwix running from years ago. #484 #485 XSCE/xsce@2a62885

@jvonau
Copy link
Contributor

jvonau commented Dec 27, 2022

Perhaps there could be a new variable that could enable the cron routine on demand in place of just restarting as I think that wipes out the cache of search history that was built up within kiwix-serve.

@holta
Copy link
Member Author

holta commented Dec 27, 2022

Guess I should of asked if the 4am restart of kiwix is even still required as this was originally a cheap workaround to keep kiwix running from years ago. #484 #485 XSCE/xsce@2a62885

kiwix-serve has very regular bugs as it make strides evolving + improving, as part of a continual community process, which cannot be fully predicted one month to the next. As such the 4AM reboot serves to help protect communities/schools/users on a valuable ongoing basis.

@holta holta merged commit fa8d05b into iiab:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants