New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update matomo-nginx.conf.j2 ["fix the error private directories are accessible"] #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix security problems noted in iiab#3441.
Move file to higher precedence to handle non-php files as well.
holta
changed the title
Update matomo-nginx.conf.j2
Update matomo-nginx.conf.j2 ["fix the error private directories are accessible"]
Jan 7, 2023
Example output of http://box/matomo (username: Admin, password: changeme) > ⚙️ (Administration) > Diagnostic > System Check below: (This was a fresh install of IIAB on the latest Ubuntu Server 23.04 daily build.)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug:
Security problems noted in #3441.
Description of changes proposed in this pull request:
Adds a line in the nginx config for Matomo barring browser access to any files in several recommended directories. This is the preferred fix method according to Matomo's docs (link, see "Nginx web server", or scroll your eyes to the next section "Other web server" to save yourself a click on seeing what their Nginx conf is doing).
Smoke-tested on which OS or OS's:
multipass 22.04 Small Matomo install
Mention a team member @username e.g. to help with code review:
@holta