Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 2210 2304 fixed https://bugs.launchpad.net/bugs/1951586 [netplan WiFi country code / regulatory domain] #3537

Merged
merged 12 commits into from Apr 19, 2023

Conversation

jvonau
Copy link
Contributor

@jvonau jvonau commented Apr 14, 2023

See url, don't need workaround netplan going forward

@holta
Copy link
Member

holta commented Apr 14, 2023

Wow!

@holta holta added the question label Apr 14, 2023
@holta holta added this to the 8.1 milestone Apr 14, 2023
@holta
Copy link
Member

holta commented Apr 14, 2023

Does this improvement apply to Ubuntu 22.10 and 23.04 exclusively?

(Never affected Ubuntu 22.04 and Mint 21 apparently?)

@holta holta changed the title RFC 2210 2304 fixed https://bugs.launchpad.net/bugs/1951586 RFC 2210 2304 fixed https://bugs.launchpad.net/bugs/1951586 [netplan WiFi country code] Apr 14, 2023
@holta
Copy link
Member

holta commented Apr 14, 2023

PR #3078 added very useful context here:

# covers netplan's bugs workaround
# https://bugs.launchpad.net/ubuntu/+source/linux-firmware/+bug/1862760
# https://bugs.launchpad.net/netplan/+bug/1951586
# WiFi country code progress on arm64 OS's discussed on #3078

Is some of that still relevant? (Or should most of the above lines perhaps be trimmed?)

@jvonau
Copy link
Contributor Author

jvonau commented Apr 15, 2023

Does this improvement apply to Ubuntu 22.10 and 23.04 exclusively?

Depends on if the netplan improvement made it into the other releases.

(Never affected Ubuntu 22.04 and Mint 21 apparently?)

Quite the opposite, those would be affected by the bug unless the fix is pushed to those releases. This change doesn't care about which release, if the country is set leave it alone otherwise doctor up the file.

@holta
Copy link
Member

holta commented Apr 15, 2023

Does netplan.io version number matter?

Ubuntu 22.04.2 and Mint 21 (apt updated) show:

# apt list -a netplan.io
Listing... Done
netplan.io/jammy-updates,now 0.105-0ubuntu2~22.04.3 amd64 [installed,automatic]
netplan.io/jammy 0.104-0ubuntu2 amd64

Ubuntu 23.04 (apt updated) shows:

# apt list netplan.io
Listing... Done
netplan.io/lunar,now 0.106-0ubuntu3 amd64 [installed,automatic]

@holta
Copy link
Member

holta commented Apr 15, 2023

Does netplan.io version number matter?

Which version of Ubuntu is most important to test if @EMG70 or others have time?

If so, what test sequence is most important?

(Would testing on an old 64-bit laptop possibly be sufficient?)

@jvonau
Copy link
Contributor Author

jvonau commented Apr 15, 2023

All of the info is in the upstream ticket, grok that for the needed info.

@holta
Copy link
Member

holta commented Apr 15, 2023

A short summary is needed for @EMG70 and/or others volunteering their time to test.

@jvonau
Copy link
Contributor Author

jvonau commented Apr 15, 2023

A short summary is needed for @EMG70 and/or others volunteering their time to test.

Well testing netplan's networkd's wifi config would need to use the first boot config file mentioned but all you would be testing is a potential bug that is a bit tricky to uncover. In the current master there would be a potential to have duplicate country= lines within what becomes the wpa_supplicant config file within /run/netplan/

@holta
Copy link
Member

holta commented Apr 15, 2023

Thanks for the explanation.

Hopefully netplan.io 0.107 & Ubuntu 23.10 are more understandable later this year — in preparation for Ubuntu 24.04 LTS in almost exactly 1 year.

@jvonau
Copy link
Contributor Author

jvonau commented Apr 15, 2023

apt changelog netplan.io should be able to tell you what is in each revision.

@holta
Copy link
Member

holta commented Apr 16, 2023

As @jvonau knows, but if others are trying to make sense of this...

https://github.com/canonical/netplan/releases indicates Country Code / Regulatory Domain became part of netplan's main branch on 2022-06-30, and a part of netplan 0.105 on 2022-08-18:

FWIW rpi-imager started to take taken advantage on 2022-07-31:

Related:

@jvonau
Copy link
Contributor Author

jvonau commented Apr 16, 2023

The last commits should compliment 3179 finishing off WiFi country detection on all platforms.

@holta
Copy link
Member

holta commented Apr 16, 2023

@EMG70 has very generously offered to help test.

If there are clear instructions, working with any specific Ubuntu that we recommend?

(But I'm not sure what's most important to test.)

@jvonau
Copy link
Contributor Author

jvonau commented Apr 16, 2023

@holta
Copy link
Member

holta commented Apr 16, 2023

https://ubuntu.com/tutorials/how-to-install-ubuntu-on-your-raspberry-pi using 'configure wireless LAN' on the server addition

The rpi-imager program changes reasonably often, but FYI https://ubuntu.com/tutorials/how-to-install-ubuntu-on-your-raspberry-pi#3-using-advanced-options helpfully shows a "Wireless LAN country" setting here, that @EMG70 might try with Ubuntu SERVER 23.04 after it's released Thursday: (2023-04-20)

image

Or maybe try the pre-release Beta here: https://releases.ubuntu.com/lunar/

@holta
Copy link
Member

holta commented Apr 16, 2023

RasPiOS country code details are separate from this ticket, but not terribly far afield — so just FYI use Ctrl-F to see the 43 mentions of "country" on this page if necessary:

https://www.raspberrypi.com/documentation/computers/configuration.html

@jvonau
Copy link
Contributor Author

jvonau commented Apr 17, 2023

Better pic of the country code setting:
0fc4bea1a4c07ebc25458720951e6e47558e43f7_2_690x448

@EMG70
Copy link
Contributor

EMG70 commented Apr 17, 2023

I will try the pre-release beta in next two days then wait for Thursday release date and let you know.

@holta
Copy link
Member

holta commented Apr 17, 2023

I will try the pre-release beta in next two days then wait for Thursday release date and let you know.

It's possible of course... that Ubuntu 23.04's Beta ends up being nearly identical to Thursday's final release.

@EMG70
Copy link
Contributor

EMG70 commented Apr 19, 2023

@jvonau's suggestion above looks good, if in fact Admin Console did not quite get installed.

Do http://localhost and http://localhost/admin both work — loading in the Raspberry Pi 400's own browser — i.e. on the attached screen?

CLARIF... here's a foolproof way to verify Admin Console is installed... since this is a headless OS (Ubuntu Server 23.04 Beta) use a text browser (in any terminal/console on the Raspberry Pi 400) to try things like...

lynx http://localhost
lynx http://localhost/admin

37B2E535-236A-4859-B52A-845F9140C0D1
Currently running iiab-network,should be done soon

@EMG70
Copy link
Contributor

EMG70 commented Apr 19, 2023

@jvonau's suggestion above looks good, if in fact Admin Console did not quite get installed.

Do http://localhost and http://localhost/admin both work — loading in the Raspberry Pi 400's own browser — i.e. on the attached screen?

CLARIF... here's a foolproof way to verify Admin Console is installed... since this is a headless OS (Ubuntu Server 23.04 Beta) use a text browser (in any terminal/console on the Raspberry Pi 400) to try things like...

lynx http://localhost
lynx http://localhost/admin

37B2E535-236A-4859-B52A-845F9140C0D1 Currently running iiab-network,should be done soon

CA278F0D-5DA3-4AC1-B65C-8ADFCB84676B

@jvonau
Copy link
Contributor Author

jvonau commented Apr 19, 2023

http://sprunge.us/e6hvWp's install log clearly shows 27c3b1b being applied, that was the point of this test box.

jerryv@box:/opt/iiab/iiab$ sudo git log
commit 8f31bfc790a87062ebe17fe98d656a3740e38185 (HEAD -> reg_dom)
Merge: ccc074ee b286d9d6
Author: iiab-local <iiab-local@iiab.local>
Date:   Wed Apr 19 12:31:56 2023 -0500

    Merge branch 'reg_dom' of https://github.com/jvonau/iiab into reg_dom

commit b286d9d6e940195d7d6dbc58479d0a98489c5ed8
Author: Jerry Vonau <jvonau3@gmail.com>
Date:   Wed Apr 19 10:46:45 2023 -0500

    easier diff

With the rest of the hand testing done think this is good enough for now.

@EMG70
Copy link
Contributor

EMG70 commented Apr 19, 2023

http://sprunge.us/e6hvWp's install log clearly shows 27c3b1b being applied, that was the point of this test box.

jerryv@box:/opt/iiab/iiab$ sudo git log
commit 8f31bfc790a87062ebe17fe98d656a3740e38185 (HEAD -> reg_dom)
Merge: ccc074ee b286d9d6
Author: iiab-local <iiab-local@iiab.local>
Date:   Wed Apr 19 12:31:56 2023 -0500

    Merge branch 'reg_dom' of https://github.com/jvonau/iiab into reg_dom

commit b286d9d6e940195d7d6dbc58479d0a98489c5ed8
Author: Jerry Vonau <jvonau3@gmail.com>
Date:   Wed Apr 19 10:46:45 2023 -0500

    easier diff

With the rest of the hand testing done think this is good enough for now.

All Good,Thanks.

@holta holta merged commit 671343b into iiab:master Apr 19, 2023
@jvonau
Copy link
Contributor Author

jvonau commented Apr 20, 2023

Some takeaways from all this:

  1. Using imager's to set the wifi credentials results in the wired eth0 device not be enabled post install and gets placed under the LAN bridge.
  2. Editing network-config preinstall of armU2304server or /etc/netplan/ post install can add in the missing eth0 definition.
  3. Adding 'band: 2.4GHz' to the netplan wifi definition limits the wlan0 wifi client to 2.4 resulting in hotspot being usable when the 'ssid' is common on both 2.4/5GHz bands.

@EMG70
Copy link
Contributor

EMG70 commented Apr 20, 2023

Good summary there Jerry ,easy to understand the test.

@jvonau jvonau mentioned this pull request Apr 20, 2023
@EMG70
Copy link
Contributor

EMG70 commented Apr 20, 2023

@jvonau ,Not sure this issue is related to this PR.
I have accidentally found out that if I connect my server to an ethernet cable and VPN is enabled post install, I can access iiab home page from any device connected to my Sky home router without hooking up via IIAB hotspot.
This happens across OS systems ,just tried on Debian 11 desktop,23.04 server and desktop ,same happens.
Can I assume devices are being connected via this VPN tunnel?

@EMG70
Copy link
Contributor

EMG70 commented Apr 20, 2023

34E7B91A-A8D1-421F-8D66-E1AFD95569C6
E93056E8-B4AF-465D-8A57-302E84CBA67A

@EMG70
Copy link
Contributor

EMG70 commented Apr 20, 2023

8F1872C7-012D-4932-9B1C-37BA69646820

@EMG70
Copy link
Contributor

EMG70 commented Apr 20, 2023

59F1C9E8-C23B-4C17-8F40-6AC28744584C

@EMG70
Copy link
Contributor

EMG70 commented Apr 20, 2023

59F1C9E8-C23B-4C17-8F40-6AC28744584C

Above screenshot from 23.04 pre-release we worked on yesterday’s .However ,accessing via home router happens when VPN is enabled across all IIAB installations.

@holta
Copy link
Member

holta commented Apr 20, 2023

@EMG70 I suspect VPN is completely unrelated?

e.g. if every device in your home can reach http://box — presumably because your home router is helping to resolve that to either of your Ubuntu Server 23.04 on RPi 400's current 2 IP addresses...

  • 192.168.0.33 == wlan0
  • 192.168.0.38 == eth0

@jvonau
Copy link
Contributor Author

jvonau commented Apr 20, 2023

Simple test turn off the vpn and see if you can continue to access the home page. Most likely your router is providing local dns name resolution for your private lan.

@EMG70
Copy link
Contributor

EMG70 commented Apr 20, 2023

Without VPN I cannot access iiab but only when enabled.

@jvonau
Copy link
Contributor Author

jvonau commented Apr 20, 2023

I'm at a loss to explain what you are experiencing, over to Adam.

@jvonau
Copy link
Contributor Author

jvonau commented Apr 20, 2023

Followup in the new issue please.

@EMG70
Copy link
Contributor

EMG70 commented Apr 20, 2023

I'm at a lose to explain what you are experiencing, over to Adam.

I apologise, I have turned VPN enabled-False but can still access iiab via home router.
This could have been happening all along without noticing.

@EMG70
Copy link
Contributor

EMG70 commented Apr 20, 2023

8637A2B8-CCCB-4DF9-B74A-078ACF6B120C

After disabling VPN

@jvonau
Copy link
Contributor Author

jvonau commented Apr 20, 2023

Um tun0 is still present in this picture

@EMG70
Copy link
Contributor

EMG70 commented Apr 20, 2023

Um tun0 is still present in this picture

297134DB-A9B9-4769-A45E-4C471CB20428

@EMG70
Copy link
Contributor

EMG70 commented Apr 20, 2023

With tun0 completely removed, I can no longer access IIIAB via home router.

@EMG70
Copy link
Contributor

EMG70 commented Apr 20, 2023

I have just tried as Adam advised to log via IP 192…33 & 192…38 I can confirm I can still access iiab via home router.
Apologies I have to leave for work now.Catch up tomorrow.

@jvonau
Copy link
Contributor Author

jvonau commented Apr 21, 2023

As @jvonau knows, but if others are trying to make sense of this...

https://github.com/canonical/netplan/releases indicates Country Code / Regulatory Domain became part of netplan's main branch on 2022-06-30, and a part of netplan 0.105 on 2022-08-18:

* PR [Allow setting the regulatory domain (LP: #1951586) canonical/netplan#281](https://github.com/canonical/netplan/pull/281)

* https://bugs.launchpad.net/netplan/+bug/1951586

FWIW rpi-imager started to take taken advantage on 2022-07-31:

* [raspberrypi/rpi-imager@31252bf](https://github.com/raspberrypi/rpi-imager/commit/31252bf1c4af5c375fc7588855f7da8ca4b6a585)

Not quite accurate that commit was later reversed
raspberrypi/rpi-imager@2c00c64
Opened:
https://bugs.launchpad.net/ubuntu/+source/rpi-imager/+bug/2016911

@holta
Copy link
Member

holta commented Apr 21, 2023

Not quite accurate that commit was later reversed
raspberrypi/rpi-imager@2c00c64
Opened:
https://bugs.launchpad.net/ubuntu/+source/rpi-imager/+bug/2016911

Maybe quick mention this (link to the above) within rpi-imager's GitHub repo?

https://github.com/raspberrypi/rpi-imager/issues

@holta holta changed the title RFC 2210 2304 fixed https://bugs.launchpad.net/bugs/1951586 [netplan WiFi country code] RFC 2210 2304 fixed https://bugs.launchpad.net/bugs/1951586 [netplan WiFi country code / regulatory domain] Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants