Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 8 #3659

Merged
merged 6 commits into from Oct 14, 2023
Merged

Patch 8 #3659

merged 6 commits into from Oct 14, 2023

Conversation

jvonau
Copy link
Contributor

@jvonau jvonau commented Oct 12, 2023

Fixes bug:

RasPiOS

Description of changes proposed in this pull request:

Ubuntu's Netplan has both NM and sysd preinstalled, account for what RasPiOS might be missing

Smoke-tested on which OS or OS's:

not yet

Mention a team member @username e.g. to help with code review:

@holta holta added this to the 8.1 milestone Oct 12, 2023
Copy link
Member

@holta holta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dangling quotes can be removed.

@@ -1,4 +1,15 @@
# sysd-netd-debian.yml
- name: 'Install networkd-dispatcher
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: 'Install networkd-dispatcher
- name: Install networkd-dispatcher

name:
- networkd-dispatcher # 15kB download: Dispatcher service for systemd-networkd connection status changes

- name: 'Install systemd-resolved for RasPiOS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: 'Install systemd-resolved for RasPiOS
- name: Install systemd-resolved for RasPiOS 12+

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ansible (via GitHub Actions) chokes on dangling quotes:

https://github.com/jvonau/iiab/actions/runs/6490464817/job/17626277491

@holta
Copy link
Member

holta commented Oct 12, 2023

Should sysd-netd-debian.yml install apt package systemd-resolved onto... every OS that offers that package?

Along the lines of this bash code?

if apt-cache show systemd-resolved > /dev/null; then
    apt -y install systemd-resolved
fi

Is something like that useful? (If so, here are 2 quick-and-dirty Ansible stubs doing the same thing...)

- name: Install systemd-resolved (if apt package available)
  shell: apt -y install systemd-resolved || true
- name: Install systemd-resolved (if apt package available)
  package:
    name: systemd-resolved
  ignore_errors: yes

@tim-moody
Copy link
Contributor

I take it there is no case where systemd-resolved is both a separate package and installed by systemd.

@tim-moody
Copy link
Contributor

After I removed the two syntax errors this ran to completion on rpi4 with 2023-10-10-raspios-bookworm-armhf-lite.img.

hostapd is running.

@tim-moody
Copy link
Contributor

my laptop connected over hotspot and box.lan was resolved
not sure what other tests are needed

@tim-moody
Copy link
Contributor

using AdmCons added password to hotspot. laptop connected securely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants