Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend ansible-core 2.16.1 [requires patching validate_vars.yml to use 'loop' instead of 'with_items' with 'assert' conditional templating] #3679

Merged
merged 3 commits into from Dec 4, 2023

Conversation

@holta holta added this to the 8.1 milestone Dec 4, 2023
@holta
Copy link
Member Author

holta commented Dec 4, 2023

CLARIF: 9f00b7b patches roles/0-init/tasks/validate_vars.yml to deal with ansible-core 2.16.1's very strict new disallowing of templated vars in some situations with when, until or assert.

Ansible's official explanations here:

Excerpt:

Conditionals - due to mitigation of security issue CVE-2023-5764 in ansible-core 2.16.1, conditional expressions with embedded template blocks can fail with the message “Conditional is marked as unsafe, and cannot be evaluated.”

Conclusion:

Basic smoke-tests now pass installing IIAB onto various versions of Ubuntu...

But please everyone keep an eye on this just in case LARGE-sized IIAB installs (or other IIAB Apps, ETC) might possibly encounter similar Ansible issues in coming days!

@holta holta changed the title Recommend ansible-core 2.16.1 Recommend ansible-core 2.16.1 [requires patching validate_vars.yml to use 'loop' instead of 'with_items' with 'assert' conditional templating] Dec 4, 2023
@holta holta merged commit 9586639 into iiab:master Dec 4, 2023
3 checks passed
@holta
Copy link
Member Author

holta commented Dec 4, 2023

FYI a LARGE-sized IIAB install smoke test is now underway (on the latest pre-release of Ubuntu Server 24.04) to further validate that ansible-core 2.16.1 hopefully doesn't cause more/other problems.

@holta
Copy link
Member Author

holta commented Dec 5, 2023

FYI a LARGE-sized IIAB install smoke test is now underway (on the latest pre-release of Ubuntu Server 24.04) to further validate that ansible-core 2.16.1 hopefully doesn't cause more/other problems.

Looking good so far but the 10GB VM ran out of disk space while installing Sugarizer, so I'm now running a more thorough LARGE-size IIAB install test.

@holta
Copy link
Member Author

holta commented Dec 5, 2023

now running a more thorough LARGE-size IIAB install test.

Completed (success!)

@holta
Copy link
Member Author

holta commented Dec 7, 2023

CLARIF: 9f00b7b patches roles/0-init/tasks/validate_vars.yml to deal with ansible-core 2.16.1's very strict new disallowing of templated vars in some situations with when, until or assert.

Ansible's official explanations here:

Excerpt:

Conditionals - due to mitigation of security issue CVE-2023-5764 in ansible-core 2.16.1, conditional expressions with embedded template blocks can fail with the message “Conditional is marked as unsafe, and cannot be evaluated.”

Conclusion:

Basic smoke-tests now pass installing IIAB onto various versions of Ubuntu...

But please everyone keep an eye on this just in case LARGE-sized IIAB installs (or other IIAB Apps, ETC) might possibly encounter similar Ansible issues in coming days!

Ansible admitted they screwed up with Mon Dec 4th's release of ansible-core 2.16.1 ;)

IIAB worked around this so we're all set.

But FYI they're suddenly going to release ansible-core 2.16.2 on Mon Dec 11th to clean up the mess:

https://groups.google.com/g/ansible-announce/c/LSZW2qILvbk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant