-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from proto
to R6
for all classes
#44
Comments
To do at a later point. Apparently R7 is the newest hot stuff but has not yet matured to a post-beta version. |
* Class type conversions from proto to R6 and documentation #44 * Turning zoom meetings into documentation #44 * All proto classes renamed and removed #44 * All bdproto calls removed throughout #44 * `bdproto` now also from engines removed #44 * All tests solve without issues #44 * Minor doc fixes before merge #44
Closed and implemented now in |
Perfect! I still have some unmerged changes on a local branch fixing a few of the notes. Will look into this next week how to merge. |
So R6 objects get changed outside the scope of a function? So for example
would change the object This seems to be an issue for some functions (e.g., Also, the behavior is not consistent across functions I think. For example |
Also, it seems that the |
I found a similar behaviour for |
Yes, but I think I changes this throughout so that the class information is saved as public (or private) attribute instead. If there are still come functions in the package that do a class check, this needs to be changed. |
Ok, fixed both issues including the class import check in Reopen the issue if you think there is something else that did not work following the |
* 🚋 ride for 🐛 fixing in threshold and ensemble * Update CITATION.cff * Small fix with weighted mean and multi-band rasters * gdalUtilities switch, removing PCA for now owing to unit test issues downstream. * Fixing previous 🐛 introduced through controls revamping * Make sure partial is consistent across methods and works for several x.var * Kleines Upsi mit aes und ggplot2 * Bugfix in partial gdb when only_linear = F * x axis label for partial * All x.var = NULL for partial() * Make ribbons easier to see * Inconcistency in partial breg for newdata * Some minor fixes partial engines * Fix and clean gdb partial * Fix stan partial * Cln docs (#85) * Remove usage (constructed automatically) * Update globals * Fix truncated examples * Remove exportMethod (export should be enough) * Fixing and cleaning docs for RCMD * Some re-ordering and cleaning of DESCRIPTION and ibis.iSDM-package.R * Remove @method tag (roxygen should be able to figure it out itself) * Added @method were actaully needed * Remove not need @import sf * Cleaner ImportFrom * Small cosmetic changes to docs * Revert "Small cosmetic changes to docs" This reverts commit 6265e89. * Small cosmetic doc changes * Make internals easier to find * Keywords dont need a comma * Fixed introduced bug in examples * sf and stars dont export their classes, so we cant use @importClassesFrom * Update NEWS * I dont think we need to export the setOldClass call? * Only include scripts that define classes and methods * Make sure pgkdown.yml still runs * Update CITATION.cff * Remove skip_on_travis (deprecated) * Added parameter to allow threshold compositing #84 * Changing class and objects to R6 throughout (#88) * Class type conversions from proto to R6 and documentation #44 * Turning zoom meetings into documentation #44 * All proto classes renamed and removed #44 * All bdproto calls removed throughout #44 * `bdproto` now also from engines removed #44 * All tests solve without issues #44 * Minor doc fixes before merge #44 * Update CITATION.cff * Small documentation fix and vignette fix for runner * Documentation update and `rm_biodiversity` addition. * fix #91 * close #92 * Use update.formula to be consistent * Clone model before writting to disk. Bug in load_model due to missing engine class (outcommented for now) * Adding wrap_model function * Fix for object inheritance and class checks #44 * Added default parameters for all ibis specific options #90 * No warning thin_obs removing ojbects * Small 🐛 fix to `write_output` * 🐛 Adding 1e-15 to y_pred in logloss * Changing behaviour of weights in `engine_inlabru()` #93 --------- Co-authored-by: Martin-Jung <Martin-Jung@users.noreply.github.com> Co-authored-by: mhesselbarth <mhk.hesselbarth@gmail.com>
There is some indication that this will have benefits in terms of memory efficiency. Thus we should at some point switch to objects defined by the
R6
package instead.The text was updated successfully, but these errors were encountered: