Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional warning messages to engines with regards to assumptions and applicability #45

Closed
3 tasks done
Martin-Jung opened this issue Apr 5, 2023 · 1 comment
Closed
3 tasks done
Assignees
Labels
improvement Smaller improvements to existing features Quality of life Quality of life improvement

Comments

@Martin-Jung
Copy link
Collaborator

Martin-Jung commented Apr 5, 2023

Many engine in the package can be particular data hungry or make certain assumptions about the input data provided to the package. Further messages via myLog in a highlighted colour should be added directly to the engines to make users aware of any violations of assumptions.

Update:
Additionally or alternatively, a better idea would be to add a simple wrapper that tests common model assumptions implemented in a specific function check(fit).

  • Implement such a function (check) in a seperate call.
  • Implement engine and parameter specific posthoc checks.
  • Add a test
@Martin-Jung Martin-Jung added Quality of life Quality of life improvement improvement Smaller improvements to existing features labels Apr 5, 2023
@Martin-Jung Martin-Jung self-assigned this Apr 5, 2023
Martin-Jung added a commit that referenced this issue Jul 21, 2023
* Update CITATION.cff

* Update CITATION.cff

* Smaller bug fixes and name sanitations

* Update CITATION.cff

* Prelunch commit. Some smaller fixes to make writing and loading models work

* Update CITATION.cff

* Pre-party commit. Similarity still not working yet.

* Update CITATION.cff

* Several updates, most notably improved 5 parameter Richards curve for offset calculations

* Re-build README.md

* Attempt to fix ci-error in tests

* Small fix for tests

* another attempt for ci fix

* Update to version 0.0.5 (#53) (#54)

* Update CITATION.cff

* Update CITATION.cff

* Smaller bug fixes and name sanitations

* Update CITATION.cff

* Prelunch commit. Some smaller fixes to make writing and loading models work

* Update CITATION.cff

* Pre-party commit. Similarity still not working yet.

* Update CITATION.cff

* Several updates, most notably improved 5 parameter Richards curve for offset calculations

* Re-build README.md

* Attempt to fix ci-error in tests

* Small fix for tests

* another attempt for ci fix

---------

Co-authored-by: Martin-Jung <Martin-Jung@users.noreply.github.com>

* Small bugfix related to ensemble and min/max of terra (#55)

* Small bugfix related to ensemble and min/max of terra

* Small bugfix related to ensemble and min/max of terra

* Update tests for ensemble

* Addition of MCP limits to `distribution`

* Update CITATION.cff

* Bug and documentation fixes

* Update CITATION.cff

* Started with implementation of check function #45

* Fix Missing link warning

* Smaller documentation fixes

* Update CITATION.cff

* Warning and documentation fixes, adding aliases

* Update CITATION.cff

* Small hotfix for gh-pages and aliases

* Update CITATION.cff

* Small fix to validate

* Fix two minor issues related to imports

* Update CITATION.cff

* Removed documentation whitespaces and minor conversion bug fix

* Smaller fixes and implementation of #57

* Hotfix (:fire:) that pkgdown does not break

* Small scenario addition and documentation fix.

* Implementation of limiting function (#37) and minor bug fixes

* 🐛 fix 😪

* Update CITATION.cff

---------

Co-authored-by: Martin-Jung <Martin-Jung@users.noreply.github.com>
Co-authored-by: Maximilian Hesselbarth <mhk.hesselbarth@gmail.com>
Co-authored-by: mhesselbarth <mhesselbarth@users.noreply.github.com>
@Martin-Jung
Copy link
Collaborator Author

Closing for now with 4179be6. Further checks to be added on demand...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Smaller improvements to existing features Quality of life Quality of life improvement
Projects
None yet
Development

No branches or pull requests

1 participant