New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add citation file #695
Add citation file #695
Conversation
c8b6d2f
to
27b3902
Compare
Codecov Report
@@ Coverage Diff @@
## main #695 +/- ##
=====================================
Coverage 94.9% 94.9%
=====================================
Files 42 42
Lines 3400 3400
=====================================
Hits 3229 3229
Misses 171 171 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me, a few small comments below in line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, going in the right direction!
Change two names Change message Add an ORCID id Fix typos
…into add_citation_file
Do we need to update https://docs.messageix.org/en/stable/notice.html or the corresponding NOTICE.rst in the main repo? The information there is still correct, we might still want to add a section about using our new file for citation. I don't yet know how to do that, but I could read up on it. However, if you want it done asap and have worked with cff files before, you might want to take on that part. |
Good idea @glatterf42! I suggest to add a reference/link to the citation file as an item in the list of section 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me.
One small final side note, maybe you could write somewhere that this file needs to be updated with every release as it contains a direct reference to the version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having the version hard-coded in the citation file means that this has to be changed explicitly as part of the release-PR. In pyam, there is a specific Release Procedure - does this exist for message_ix as well?
Please add an reminder to change the citation.cff to the release-procedure document - or better to not state the version explicitly in this file at all.
cc @khaeru
I think it might be useful to include some version information. Future versions might not be able to reproduce results, so project scientists might want to pinpoint specific versions as the ones that worked for them. On that regard, I've found a Github Action to automatically update the citation file, so we should be able to include this information without needing to worry about manual updates. The only downside is that I haven't really worked with Github Actions yet, so I'll have to spend some time understanding how they work, but then I should be able to adapt this workflow to our needs. |
But the version-information is already included in your workflow/script simply by doing |
On that note, the pyam citation file also contains a version keyword, referencing version 1.0. |
True, but the pyam-citation refers to the manuscript in Open Research Europe, which is specifically linked to v1.0 of the package. But this could obviously lead to some confusion there, too... |
Change version to valid type Reintroduce commit parameter Add workflow to automatically update both
So: in part, I just wanted to see if I could do it. Even if we don't end up using what I cooked up here, I have learned a lot about Github Actions in the process :) All in all, I think providing the version and commit information is comfortable, accurate, and not much work with the addition of the workflow. cc @khaeru |
* Remove workflow to automatically update those
Together with @khaeru, I just noticed that the automatically created Bibtex entry does not contain a lot of information. For starters, it's just one entry, so we can choose for it to be the software entry or the paper entry. Even if we choose the software entry, the only versioning information would be month and year of the "date-released" entry. So I also don't think there's a point to keep them automatically up-to-date for this feature. Maybe some of the other tools could make use of the data, but for now, I removed them from the citation file. |
* Include pre-print url of manuscript in citation file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
Add a citation file of format CITATION.cff to address issue #691.
How to review
To review, please
PR checklist
Add or expand tests; coverage checks bothNo change in behaviour.