Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling to change volume does not give visual feedback in music mode #2999

Open
1 task
anohren opened this issue Jun 17, 2020 · 0 comments
Open
1 task

Scrolling to change volume does not give visual feedback in music mode #2999

anohren opened this issue Jun 17, 2020 · 0 comments
Assignees
@uiryuu
Labels
type: enhancement

Comments

@anohren
Copy link
Contributor

anohren commented Jun 17, 2020 •
edited
Loading

System and IINA version:

  • macOS
  • IINA 1.0.7

Expected behavior:
Scrolling to change volume in music mode shows the volume slider popover.

Actual behavior:
It gives zero visual feedback and is therefore of questionable use in music mode. See conversation in #2191 for already refined behavior of the volume popover.

Crash report:

mpv log:

Steps to reproduce:

  • MPV does not have this problem.

How often does this happen?
@anohren anohren mentioned this issue Jun 17, 2020
Closed
2 tasks
@uiryuu uiryuu self-assigned this Jun 17, 2020
@uiryuu uiryuu added this to the 1.1.0 milestone Jun 17, 2020
uiryuu added a commit that referenced this issue Jun 17, 2020
@uiryuu
Show volume popover when scrolling to adjust in miniplayer
55f5d1c 
Ref: #2999, #2191

Co-authored-by: LEoREo2247 <info@dev.ringo-12.com>
@uiryuu uiryuu mentioned this issue Jun 17, 2020
Closed
1 task
uiryuu added a commit that referenced this issue Jun 29, 2020
@uiryuu
Show volume popover when scrolling to adjust in miniplayer
332586e 
Ref: #2999, #2191

Co-authored-by: LEoREo2247 <info@dev.ringo-12.com>
lhc70000 pushed a commit that referenced this issue Jul 10, 2020
@uiryuu @lhc70000
Show volume popover when scrolling to adjust in miniplayer
664ad7b 
Ref: #2999, #2191

Co-authored-by: LEoREo2247 <info@dev.ringo-12.com>
0111b pushed a commit to 0111b/iina that referenced this issue Nov 7, 2020
@uiryuu @0111b
Show volume popover when scrolling to adjust in miniplayer
16d8045 
Ref: iina#2999, iina#2191

Co-authored-by: LEoREo2247 <info@dev.ringo-12.com>
@uiryuu uiryuu removed this from the 1.1.0 milestone Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uiryuu uiryuu

Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anohren @uiryuu