Added scroll controlling to mini player #2191
Conversation
|
You don't explicitly say what is being controlled by scrolling, but I assume it's exclusively the volume. Edit: Right, now I saw the issue reference. That's exactly what I was missing as well. Tried scrolling while hovering over the window, the album art, the volume icon, the volume popover, the volume slider -- nothing :) |
…me popover to appear It also includes minor readability improvement
Giving some delay until popover gets disappeared for the trackpad Making popover disappears AFTER user stops scrolling with the mouse
There was a problem hiding this comment.
I tested this and it seems to work pretty well. The only problem I noticed was when using a macbook trackpad to scroll, and momentarily lifting my fingers to continue the scroll in a different position on the trackpad. In those cases the animation to hide the volume popover was not cancelled, but allowed to continue even though I had already initiated a new scrolling action.
Using an external logitech mouse with discrete scrolling steps did not show the same problem.
|
From testing now I think it works really well. Scrolling reacts everywhere it should. |
uiryuu
force-pushed
the
develop
branch
2 times, most recently
from
620dce1
to
f4a83ec
Compare
|
Sorry for late reply. While I'm not oppose this idea, I see there are a lot of code share between |
|
Will be fixed by #2772 |
Description:
I did it because I personally just wanted that.
Implementation is somewhat lazy and its nearly just a copy-paste from MainWindowController.
However instead of having the dedicated OSD, this scroll controlling on mini player indicates the volume change by showing volume popover while moving trackpad/mouse.