Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With seek bar/controller moved to top left, parts of seek bar doesn't respond. #4156

Closed
haakonstorm opened this issue Jan 2, 2023 · 4 comments · May be fixed by #4180
Closed

With seek bar/controller moved to top left, parts of seek bar doesn't respond. #4156

haakonstorm opened this issue Jan 2, 2023 · 4 comments · May be fixed by #4180

Comments

@haakonstorm
Copy link

System and IINA version:

  • macOS 13.1 (on macbook air m1)
  • IINA 1.3.1 (via homebrew)

Expected behavior:

Clicking and dragging to seek in the video seeks to expected part of video.

Actual behavior:

Clicking on seek bar doesn't work if seek bar/controller is moved to top left of screen. The seek bar doesn't work in the exact area as the "notification" telling which timecode of the video you were seeking to. The notification itself overlays the seek bar.

Steps to reproduce:

  1. Move video controller to the top left (the controller with the seek bar, play, pause etc) while iina is minimized.
  2. Try to use the seek bar to seek to an area close to the beginning of the video.
  3. Iina will not seek, because clicking in this region apparently the clicks are sent to the "seek-to-notification" view in the top left, instead of to the seek bar.

Screenshot of IINA (02-01-2023, 14-31-00)

How often does this happen?

Consistently, reproducible over many versions of iina.

@svobs
Copy link
Contributor

svobs commented Jan 21, 2023

Reproduced.

Was also able to fix this easily. When I was working on #4180 I found that the Z order of each view depends on its order in Interface Builder's outline view (the left sidebar). Views lower in the list cast shadows on views higher in the list.

So the solution is just to drag the OSD view up high enough so that it precedes all the OSCs and anything else which can be clicked. Like this:
SCR-20230120-sn0

@low-batt
Copy link
Contributor

low-batt commented Mar 5, 2023

I have tested PR #4180 and confirmed it fixes this issue.

@low-batt
Copy link
Contributor

The fix for this issue has been merged into the IINA develop branch. GitHub automatically closed the linked issue in reaction to the merge. I am reopening this issue until the fix is available in an official release of IINA so that users intending to report this problem can easily locate this existing report. Once the fix for this issue has been included in an official release this issue will be closed.

@low-batt low-batt reopened this Jan 15, 2024
@low-batt
Copy link
Contributor

low-batt commented Jun 9, 2024

This was fixed in IINA 1.3.5.

@low-batt low-batt closed this as completed Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants