Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL: Incorrect arrow icon direction in browser extensions reference #4950

Closed
1 task done
ShlomoCode opened this issue May 26, 2024 · 6 comments · Fixed by #4952
Closed
1 task done

RTL: Incorrect arrow icon direction in browser extensions reference #4950

ShlomoCode opened this issue May 26, 2024 · 6 comments · Fixed by #4952
Assignees
@low-batt
Labels
bug feature: preferences progress: fixed/implemented type: localization

Comments

@ShlomoCode
Copy link
Contributor

System and IINA version:

Expected behavior:

The icon will always point to the text, even in RTL languages such as Hebrew and Arabic.

Actual behavior:

Currently IINA does not support any right-to-left languages. However PR #4922 allows Hebrew. If you build IINA with this pull request and set Hebrew as the language, you will notice that the arrows in the browser extension buttons (under the Utils tab in the settings) do not point in the direction of the text (the direction is hard-coded to the right)

CleanShot 2024-05-23 at 06 21 53@2x
CleanShot 2024-05-23 at 07 03 48@2x

Steps to reproduce:

  • Open the IINA project in Xcode
  • Under the Product menu open the Scheme menu and select Edit Scheme…
  • Click on the Options tab
  • Scroll down to the App Language setting
  • In the pull down select Right-to-Left Pseudolanguage near the end of the list
  • Start IINA running under Xcode
  • Open Settings and go to Utils section
  • Notice that the arrows are not facing the text
  • MPV does not have this problem.

mpv does not support localization.

How often does this happen?

Every time.
@ShlomoCode ShlomoCode changed the title RTL: Incorrect arrow icon direction in reference to browser extensions RTL: Incorrect arrow icon direction in browser extensions reference May 26, 2024
@low-batt low-batt self-assigned this May 26, 2024
@low-batt
Copy link
Contributor

@ShlomoCode Does it look the same when the system language is Hebrew?

@ShlomoCode
Copy link
Contributor Author

ShlomoCode commented May 26, 2024 •
edited
Loading

@ShlomoCode Does it look the same when the system language is Hebrew?

Yes (even after restart)
CleanShot 2024-05-26 at 06 35 59@2x

@low-batt
Copy link
Contributor

Thanks for checking. I see the problem. I was confused by the terminology. Working on a fix.

low-batt added a commit that referenced this issue May 26, 2024
@low-batt
Fix RTL: Wrong arrow icon direction in browser buttons, #4950
3ea5000 
This commit will change the mirror property of the Chrome and Firefox
buttons on the Utilities tab from automatically to never. This prevents
the arrow icon from moving to the right side of the button label when a
RTL language is configured.
low-batt added a commit that referenced this issue May 26, 2024
@low-batt
Fix RTL: Wrong arrow icon direction in browser buttons, #4950
f25301c 
This commit will change the mirror property of the Chrome and Firefox
buttons on the Utilities tab from automatically to never. This prevents
the arrow icon from moving to the right side of the button label when a
RTL language is configured.
@low-batt low-batt mentioned this issue May 26, 2024
Merged
2 tasks
@low-batt low-batt linked a pull request May 26, 2024 that will close this issue
Fix RTL: Wrong arrow icon direction in browser buttons, #4950 #4952
Merged
2 tasks
uiryuu pushed a commit that referenced this issue May 26, 2024
@low-batt
Fix RTL: Wrong arrow icon direction in browser buttons, #4950 (#4952)
b15898e 
This commit will change the mirror property of the Chrome and Firefox
buttons on the Utilities tab from automatically to never. This prevents
the arrow icon from moving to the right side of the button label when a
RTL language is configured.
@ShlomoCode
Copy link
Contributor Author

ShlomoCode commented May 26, 2024 •
edited
Loading

CleanShot 2024-05-26 at 16 03 49@2x
The arrows should stay on the right side of the button, just point towards the text and not out. See also #4937

@uiryuu
Copy link
Member

uiryuu commented May 26, 2024 •
edited
Loading

So you mean (Chrome <-) (Firefox <-), am I correct?
image
Like this?

@ShlomoCode
Copy link
Contributor Author

ShlomoCode commented May 26, 2024 •
edited
Loading

Yes

@uiryuu uiryuu mentioned this issue May 29, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@low-batt low-batt

Labels
bug feature: preferences progress: fixed/implemented type: localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix RTL: Wrong arrow icon direction in browser buttons, #4950 iina/iina
3 participants
@uiryuu @ShlomoCode @low-batt