-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL: Incorrect arrow icon direction in browser extensions reference #4950
Comments
@ShlomoCode Does it look the same when the system language is Hebrew? |
|
Thanks for checking. I see the problem. I was confused by the terminology. Working on a fix. |
low-batt
added a commit
that referenced
this issue
May 26, 2024
This commit will change the mirror property of the Chrome and Firefox buttons on the Utilities tab from automatically to never. This prevents the arrow icon from moving to the right side of the button label when a RTL language is configured.
low-batt
added a commit
that referenced
this issue
May 26, 2024
This commit will change the mirror property of the Chrome and Firefox buttons on the Utilities tab from automatically to never. This prevents the arrow icon from moving to the right side of the button label when a RTL language is configured.
2 tasks
2 tasks
uiryuu
pushed a commit
that referenced
this issue
May 26, 2024
This commit will change the mirror property of the Chrome and Firefox buttons on the Utilities tab from automatically to never. This prevents the arrow icon from moving to the right side of the button label when a RTL language is configured.
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System and IINA version:
Expected behavior:
The icon will always point to the text, even in RTL languages such as Hebrew and Arabic.
Actual behavior:
Currently IINA does not support any right-to-left languages. However PR #4922 allows Hebrew. If you build IINA with this pull request and set Hebrew as the language, you will notice that the arrows in the browser extension buttons (under the Utils tab in the settings) do not point in the direction of the text (the direction is hard-coded to the right)
Steps to reproduce:
Product
menu open the Scheme menu and selectEdit Scheme…
Options
tabApp Language
settingRight-to-Left Pseudolanguage
near the end of the listmpv does not support localization.
How often does this happen?
Every time.
The text was updated successfully, but these errors were encountered: