Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused strings in localization #4937

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

uiryuu
Copy link
Member

@uiryuu uiryuu commented May 23, 2024

Description:

- Remove strings like "Box", "Text Cell" which will not displayed in the UI
- Remove Chrome and Firefox in the localization
- Remove "strip" in `PrefSubViewController`, which will be replaced in
  in UI in runtime (#4893)
- Added `NSHumanReadableCopyright` in `InfoPlist.strings`
@ShlomoCode ShlomoCode mentioned this pull request May 23, 2024
2 tasks
@uiryuu
Copy link
Member Author

uiryuu commented May 24, 2024

@ShlomoCode Indeed. In my native language we don't translate them, so I naively thought other language would do the same. I'll revert it back.

@lhc70000 lhc70000 merged commit 452af19 into develop May 24, 2024
1 check passed
@lhc70000 lhc70000 deleted the remove-ununsed-strings branch May 24, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants