New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect equality comparison #19

Open

andrewbranch opened this issue Jul 29, 2021 · 0 comments

Collaborator

andrewbranch commented Jul 29, 2021

This will never be true since arrays are compared by reference equality. I don’t think the condition is needed, though?

ts-fix/src/index.ts

Line 70 in 90a7e5c

if (diagnosticsPerFile === [] || diagnosticsPerFile === [[]]){

iisaduan mentioned this issue

Incorrect equality comparison/edge case handling for no diagnostics microsoft/ts-fix#9

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment