Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test part 1 #9

Merged
merged 12 commits into from
Jul 30, 2021
Merged

Test part 1 #9

merged 12 commits into from
Jul 30, 2021

Conversation

LOctavio
Copy link
Collaborator

@LOctavio LOctavio commented Jul 30, 2021

Project requirements

  • This is a pair-programming project. Please decide whose project will you use for testing.

  • Create a test file ([..].test.js) for a file containing the add item and delete item functions that you want to test.

  • Take a look at each of these functions. Are they pure functions? If the answer is "yes" then writing tests for them should be straightforward. Some of those functions however will update localStorage and manipulate the DOM. For those, you will need to use mocks:

  • Mock a storage object to "imitate" localStorage operations.

  • Mock HTML to test if add/delete functions add or remove exactly one

  • element to/from the list in the DOM.

  • Make sure you group your tests using the description() method.

  • You need to use pair-programming for this project. We will check to see if both partners submitted code by looking at the commit history for each project. Therefore you need to select one of the repos in your pair-programming group in which you will implement the above features.

Copy link

@mricanho mricanho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: ✔️ Project Approved ✔️

Hello @LOctavio @IjayAbby 🔥

You did a great job with this tests, everything works as expected, you are ready for the next milestone, good luck!👍🏽

that's how you do it

Now you can merge this branch 🚀

💻 👩🏽‍💻 Happy Coding! 👨🏽‍💻 🖥️


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@LOctavio LOctavio merged commit 83460dc into main Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants