Add npm private packages support #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ije
reviewed
Oct 20, 2022
| if !fileExists(rcFilePath) { | ||
| err = ioutil.WriteFile( | ||
| rcFilePath, | ||
| []byte("_authToken=${ESM_NPM_TOKEN}"), |
There was a problem hiding this comment.
does the npmrc supports ${ESM_NPM_TOKEN} expression?
There was a problem hiding this comment.
Yup, the .npmrc is supported, Is designed for private packages in CI/CD.
But .yarnrc is not, and but .yarnrc.yml is supported 🤣 Yarn is so confused.
Actually, I tried to use other ways to implement it, such as:
- Environment variables begin with
npm_config_, but yarn will lower case all suffix, so the_authTokento be transformed to_authtoken, the_auth_tokento be transformed to_auth-token - Use
--use-yarnrc <path>for providing a specific.yarnrcfile, but it was not supported to decode the environment variable expression
There was a problem hiding this comment.
thanks for the explain! i didn't known this before
|
nice! 👍 |
|
pls ignore the testing failed, it's caused by types checking, i will fix then. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
For the business case, I want to self-hosting this server and serve with some private packages hosted on the npm-registry
Changes
npm-tokenflag to provide NPM private token.npmrcfile in the temporary yarn installing directory to provide the_authToken--no-default-rcflag of theyarn installingcommand to support reading.npmrc