fix(conf): some bugs related to package path parsing #487

ahuigo · 2023-01-05T15:16:39Z

./config.json:

  "basePath": "/",
  "npmRegistry": "https://registry.npmjs.org",

Bad Cases:

$ curl -D- http://localhost:8080/react
HTTP/1.1 302 Found
...
Location: //react

$ curl -D- http://localhost:8080/react@18.2.0
HTTP/1.1 302 Found
...
Location: http://localhost:8080//react@18.2.0

$ curl -D- http://localhost:8080/react
----server error------------
Get "https://registry.npmjs.orgreact": dial tcp: lookup registry.npmjs.orgreact: no such host

config.json: ``` "basePath": "/", "npmRegistry": "https://registry.npmjs.org", ``` Bad Cases: ``` $ curl -D- http://localhost:8080/react HTTP/1.1 302 Found ... Location: //react $ curl -D- http://localhost:8080/react@18.2.0 HTTP/1.1 302 Found ... Location: http://localhost:8080//react@18.2.0 $ curl -D- http://localhost:8080/react ----server error------------ Get "https://registry.npmjs.orgreact": dial tcp: lookup registry.npmjs.orgreact: no such host ```

ije

Look great to me, thanks~

ije approved these changes Jan 7, 2023

View reviewed changes

ije merged commit 3a58a57 into esm-dev:main Jan 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(conf): some bugs related to package path parsing #487

fix(conf): some bugs related to package path parsing #487

ahuigo commented Jan 5, 2023

ije left a comment

fix(conf): some bugs related to package path parsing #487

fix(conf): some bugs related to package path parsing #487

Conversation

ahuigo commented Jan 5, 2023

ije left a comment

Choose a reason for hiding this comment