Labeling GUI: Copy colortable

[btbest]

Not copying the list means that when a value is changed (in this case, by the user selecting another color in the ColorDialog), the original list in the colortables module import is modified. This persists until ilastik is restarted.

Fixes #2728

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5116115) 54.95% compared to head (6068654) 54.96%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2786      +/-   ##
==========================================
+ Coverage   54.95%   54.96%   +0.01%     
==========================================
  Files         530      530              
  Lines       62227    62226       -1     
  Branches     8503     8503              
==========================================
+ Hits        34197    34204       +7     
+ Misses      26271    26269       -2     
+ Partials     1759     1753       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[k-dominik]

I guess that is the shortest route for a fix one could take!

I would honestly prefer to make all the mutable colormap constants in volumina.colortables private and do the copying in some create_COLORTABLENAME functions, just to make it harder to run into such an issue again. What do you think @btbest

[btbest]

I agree with the volumina change. In the meantime, I found the bug here is even sillier than I realised. There's already self._colorTable16 = list(colortables.default16_new) literally 20 lines above, which was overwritten by the line that I'm now "fixing" in this PR 🤦 When the fix is just to remove that line...

So step 1, remove that line and merge. Step 2, fix volumina exports and release. Step 3, dependency bump and replace the usages in ilastik.