Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all object features get exported to table #2814

Merged
merged 2 commits into from Feb 23, 2024

Conversation

k-dominik
Copy link
Contributor

@k-dominik k-dominik commented Feb 16, 2024

Everytime I look at exportFile.py I want to rewrite it. In lieu of time, another hack...

Previously, only features computed in the 1st timeframe would get a column in the export table. One would expect that with this bug there would be none ;). Global features are always computed -> produce an (empty) table in every frame, but local ones, only if there are objects.

This is more a bandaid then a proper fix. It would probably be better to go from selected features (from the dialog) for
column names, but currently the plugin information is stripped from those :(

CC: @oanegros (thank you for pointing it out and helping to debug)

Previously, only features computed in the 1st timeframe would get a column
in the export table. One would expect that with this bug there would be none ;).
Global features are always computed -> produce a table, but local ones, only if
there are objects.

This is more a bandaid then a proper fix. It would probably be better to
go from `selected` features (from the dialog) for column names, but currently
the plugin information is stripped from those :(
@k-dominik k-dominik changed the title Ensure all object features get exported Ensure all object features get exported to table Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e813293) 55.75% compared to head (84dd025) 55.77%.
Report is 12 commits behind head on main.

Files Patch % Lines
ilastik/utility/exportFile.py 78.57% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2814      +/-   ##
==========================================
+ Coverage   55.75%   55.77%   +0.01%     
==========================================
  Files         530      530              
  Lines       62173    62180       +7     
  Branches     8498     8503       +5     
==========================================
+ Hits        34663    34679      +16     
+ Misses      25764    25756       -8     
+ Partials     1746     1745       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k-dominik k-dominik marked this pull request as ready for review February 19, 2024 09:20
Copy link
Contributor

@btbest btbest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, this one's a doozie... Let's say this function is hard to follow, and the naming is all over the place, but I don't feel like the addition in this PR makes it much worse either.

I also couldn't actually try out whether it fixes what it is supposed to fix. Is there a straightforward way to get a dataset where some object features are only computed from time point >0 onwards? I managed to coerce a dataset so that it has no objects in some time points, but that seems to cause errors much earlier in the workflow (see comment below).

Primarily, I would really like computed_features renamed, because it is super confusing to have it existing (and being important to the function) next to computed_feature. I suggest features_by_time. Besides that, basically just typos in the comment...

ilastik/utility/exportFile.py Show resolved Hide resolved
Co-authored-by: Benedikt Best <63287233+btbest@users.noreply.github.com>
@k-dominik k-dominik merged commit 0ddbc44 into ilastik:main Feb 23, 2024
16 checks passed
@k-dominik k-dominik deleted the fix-oc-table-features-missing branch February 23, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants