Multiscale: Support project files containing an integer working_scale #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btbest
force-pushed
the
support-projects-with-int-scale
branch
2 times, most recently
from
1e6c376
to
0f77f94
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2816 +/- ##
==========================================
- Coverage 55.76% 55.76% -0.01%
==========================================
Files 530 530
Lines 62191 62204 +13
Branches 8500 8502 +2
==========================================
+ Hits 34683 34689 +6
- Misses 25761 25773 +12
+ Partials 1747 1742 -5 ☔ View full report in Codecov by Sentry. |
All project files created with ilastik1.4.1b13 break otherwise
btbest
force-pushed
the
support-projects-with-int-scale
branch
from
0f77f94
to
6f88900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All project files created with ilastik1.4.1b13 break after switching to string-indexed scale handling. While fixing that, I also implemented handling projects with Precomputed datasets in them
It may be worth looking into version compatibility testing. It should be possible on CI; could be costly though in terms of pipeline time.