Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base sha option for changelog generation and release #40

Closed
iliapolo opened this issue Jun 27, 2019 · 1 comment · Fixed by #41
Closed

Add base sha option for changelog generation and release #40

iliapolo opened this issue Jun 27, 2019 · 1 comment · Fixed by #41
Assignees
Labels
feature This issue introduces a new feature minor Implies this code change should bump the minor version of the project

Comments

@iliapolo
Copy link
Owner

PyCI changelog generation is performed with a source sha and a target sha.

However, the source (i.e base) sha is not configurable. It always uses the sha of the latest release prior to the target sha.

This mechanism is problematic for existing projects that haven't been producing github releases. If and when these projects choose to work with PyCI, their very first release will include ALL commits in the project. This, apart from being a very slow process, is a poor experience.

To support this scenario, we can add a --changelog-base option for overriding the default behavior. This way users can specify the sha they want on initial release, after which they can . remove that specification and let PyCI do the work.

@iliapolo iliapolo mentioned this issue Jun 27, 2019
@iliapolo iliapolo added the minor Implies this code change should bump the minor version of the project label Jun 27, 2019
@iliapolo
Copy link
Owner Author

This issue is part of release 0.6.0

@iliapolo iliapolo added the feature This issue introduces a new feature label Jun 28, 2019
@iliapolo iliapolo self-assigned this Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue introduces a new feature minor Implies this code change should bump the minor version of the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant