Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom %PROGRAM_FILES% directory #65

Closed
iliapolo opened this issue Dec 7, 2019 · 1 comment
Closed

Custom %PROGRAM_FILES% directory #65

iliapolo opened this issue Dec 7, 2019 · 1 comment
Assignees
Labels
feature This issue introduces a new feature patch Implies this code change should bump the patch version of the project

Comments

@iliapolo
Copy link
Owner

iliapolo commented Dec 7, 2019

Currently, the windows installer created by PyCI is configured to always place the installation under: %PROGRAM_FILES%\%PACKAGE_NAME%.

(The %PACKAGE_NAME% is extracted form the name argument of the setup.py file)

For example, PyCI is placed under: %PROGRAM_FILES%\py-ci.

While this makes sense, sometimes the user needs ability to specify a custom program files directory.

For example, imagine the following use case:

  1. Application my-app is installed under directory my-app-win.
  2. The owner of the application now migrates to PyCI, which creates an installer for him.
  3. The installer is published, but installs the application under the my-app directory.

This causes the new installation not to override the existing one, which breaks the installation contract.

Specifying a custom program files directory will solve this problem since the owner of my-app will configure the installer to install under my-app-win.

@iliapolo iliapolo added feature This issue introduces a new feature patch Implies this code change should bump the patch version of the project labels Dec 7, 2019
@iliapolo iliapolo self-assigned this Dec 7, 2019
This was referenced Dec 7, 2019
Closed
@iliapolo
Copy link
Owner Author

iliapolo commented Dec 7, 2019

This issue is part of release 0.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue introduces a new feature patch Implies this code change should bump the patch version of the project
Projects
None yet
Development

No branches or pull requests

1 participant