-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nvlax can no longer be built because Zydis has made breaking changes #11
Comments
Can confirm editing CMakeLists.txt with
on line 19 allows the project to build. |
Please @gardotd426 provide a PR to update the master. Then almost until someone will update the code the tool will compile. |
PR waiting to merge: #14 |
nvlax can't be built anymore even with this patch, here are the logs:
This occurs both with any nvlax AUR package/utility and compiling directly from source with the patch in the PR above. |
Patch to replace each master branch call diff --git a/CMakeLists.txt b/CMakeLists.txt
index 5fa8620..ee2f230 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -16,11 +16,11 @@ project(nvlax CXX)
include(ExternalProject)
include(cmake/FetchCPM.cmake)
-CPMAddPackage("gh:zyantific/zydis#master")
+CPMAddPackage("gh:zyantific/zydis#55dd08c210722aed81b38132f5fd4a04ec1943b5")
CPMAddPackage(
NAME LIEF_SRC
- GIT_TAG master
+ GIT_TAG b65e7cca03ec4cd91f1d7125e717d01635ea81ba
GITHUB_REPOSITORY lief-project/LIEF
DOWNLOAD_ONLY YES
)
@@ -59,7 +59,7 @@ message(STATUS "LIEF library: ${LIEF_LIBRARIES}")
CPMAddPackage(
NAME PPK_ASSERT
- GIT_TAG master
+ GIT_TAG 833b8b7ea49aea540a49f07ad08bf0bae1faac32
GITHUB_REPOSITORY gpakosz/PPK_ASSERT
DOWNLOAD_ONLY YES
)
|
Nice, that fixed it, thank you! 😄 |
Updated references to master branches to use main instead as per this post on the source repo: illnyang#11 (comment)
Zydis as introduces breaking changes that prevent nvlax from being compiled.
For the time being, you could use
CPMAddPackage("gh:zyantific/zydis#55dd08c210722aed81b38132f5fd4a04ec1943b5")
orCPMAddPackage("gh:zyantific/zydis#v3.2.1")
with some regression changes needed, rather thanCPMAddPackage("gh:zyantific/zydis#master")
or make the needed changes to nvlax.The text was updated successfully, but these errors were encountered: