Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br issue #2

Closed
idansh opened this issue Dec 1, 2015 · 8 comments
Closed

br issue #2

idansh opened this issue Dec 1, 2015 · 8 comments

Comments

@idansh
Copy link

idansh commented Dec 1, 2015

When I load the editor everything works fine. When I inject the HTML of the editor and initialize it, when clicking enter, it put an extra
. So the third time, it put three
instead of one.

I don't know why it works like that, because I can't find anything in the local storage or something that remembers the last input. I override the html and the textarea.

After debugging, when I press ENTER, the line: 'easyEditor.prototype.handleKeypress' runs twice and goes to the line that prints

.

@im4aLL
Copy link
Owner

im4aLL commented Dec 1, 2015

Yes, I noticed that also when allowing multiple editors in same page. Please do pull the latest js and I slight changed the calling system. Let me know if the issue still not solved yet from latest JS.

@im4aLL
Copy link
Owner

im4aLL commented Dec 1, 2015

Also please check this URL - http://habibhadi.com/lab/easyeditor/multiple-easyeditor.html

@idansh
Copy link
Author

idansh commented Dec 1, 2015

For some reason it now throws (after I downloaded the new file) the following error in line 37:
"Uncaught TypeError: Cannot read property 'toLowerCase' of undefined".

I don't use bootstrap by the way. Any suggestions.

Until it resolved, I currently still use this line to prevent the further delegation of events, clearing them up.

  $(document).on('closing', '.remodal', function (e) {
        $('html').off()

    });

@im4aLL
Copy link
Owner

im4aLL commented Dec 1, 2015

Are you getting error in default initial or issue is occurring on any button click? Can I see any sample code of yours so that I can replicate the issue in my end?

@idansh
Copy link
Author

idansh commented Dec 1, 2015

            var easyEditor = new EasyEditor({
                element: '#user-comment-in-popup',
                buttons: ['bold', 'italic', 'quote','youtube', 'x'],
                buttonsHtml: {
                    'bold': '<i class="fa fa-bold"></i>',
                    'italic': '<i class="fa fa-italic"></i>',
                    'quote': '<i class="fa fa-quote-left"></i>',
                    'insert-youtube-video': '<i class="fa fa-youtube"></i>',
                    'remove-formatting': '<i class="fa fa-ban"></i>'
                }
            });

On init it happens.

@im4aLL
Copy link
Owner

im4aLL commented Dec 1, 2015

Yes, you are still using previous calling method. Please see the new calling method. And it should be like this

new EasyEditor('#user-comment-in-popup', { options: options});

Sorry using mobile currently.

@idansh
Copy link
Author

idansh commented Dec 1, 2015

Works flawlessly. Just adding, I went through a more than 50 WYSIWYG plugins, chose yours for its simplicity. Thanks!

@idansh idansh closed this as completed Dec 1, 2015
@im4aLL
Copy link
Owner

im4aLL commented Dec 1, 2015

Yeah man! I went through many rich text editor as well. But found those are overhead and overcoded. Though I built it recently, but it serves the purpose I guess. Some of them doesn't even allow to add simple button without payment. I believe those are good as well running from years.

My main goal is to make it simple and with minimal css so that anybody can integrate with any site with just couples of css tweaking. I made every possible options configurarable. People can add tons of buttons even any file manager with their own.

Thanks for such great feedback it will keep my inspiration ahead.

Thanks
Hadi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants