Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link input repeats itself #3

Closed
idansh opened this issue Dec 2, 2015 · 3 comments
Closed

Link input repeats itself #3

idansh opened this issue Dec 2, 2015 · 3 comments

Comments

@idansh
Copy link

idansh commented Dec 2, 2015

When I try to insert a link, the alert dialog opens up, I put a link and press the button - the same alert opens again. It happens three times even if I cancel it.

Update: it can happen more times. I thinks it delegates the same as the other issue i reported.

TIP: I think it would be better to make the prompt window not an alert, but a div that stick to the top of the text editor area (position:absolute) and upon save it closes up, better for mobile devices.

@im4aLL
Copy link
Owner

im4aLL commented Dec 2, 2015

Please pull the latest updated JS once again. Issue should be fixed. Yes, for link it will be better to have a modal like http://habibhadi.com/lab/easyeditor/upload-insert-image.html (see image button)

You can enhance yours by added a popup, to overwrite default button settings http://habibhadi.com/lab/easyeditor/overwrite-button-settings.html

Let me know if the issue still remains.

@im4aLL
Copy link
Owner

im4aLL commented Dec 3, 2015

Is that issue still remains?

@idansh
Copy link
Author

idansh commented Dec 3, 2015

I'm pulling it now, I'll report after testing. Thanks

@im4aLL im4aLL closed this as completed Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants