You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
I found an issue ("pantry-node": "^0.1.3") while trying to use pantry when the service is not available (ETIMEOUT negative case):
here is applicative logs
PANTRY DIST ERROR {"errno":-4039,"code":"ETIMEDOUT","syscall":"connect","address":"redacted:redacted:redacted::6815:1b11","port":443}
11-30 20:48:46.551 | debug | TypeError: error.text is not a function
at Request.perform (C:\WORK\redacted\node_modules\pantry-node\dist\pantry.js:37:42)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Pantry.details (C:\WORK\redacted\node_modules\pantry-node\dist\pantry.js:86:24)
I just add one line to the dist\pantry.js(l29) node_modules file to understand the response format an related error in that case:
it seems that there is a need to undertake/catch this kind of error (without text) to fix that case.
NB: another more general remark about error/success nodejs lib response desing for end-user: a short code attrbute may be a good improvement to manipulate positive/negative cases in a more easy way (ex. OK, TIMEOUT, NOT_FOUND etc..)
Thanks for this project (having free resource) :) 👍
The text was updated successfully, but these errors were encountered:
Hi,
I found an issue (
"pantry-node": "^0.1.3"
) while trying to use pantry when the service is not available (ETIMEOUT
negative case):here is applicative logs
I just add one line to the
dist\pantry.js
(l29) node_modules file to understand the response format an related error in that case:it seems that there is a need to undertake/catch this kind of error (without
text
) to fix that case.NB: another more general remark about error/success nodejs lib response desing for end-user: a short code attrbute may be a good improvement to manipulate positive/negative cases in a more easy way (ex.
OK
,TIMEOUT
,NOT_FOUND
etc..)Thanks for this project (having free resource) :) 👍
The text was updated successfully, but these errors were encountered: