Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split subtract in 2 methods ? #319

Open
lpatiny opened this issue Apr 26, 2023 · 0 comments
Open

Split subtract in 2 methods ? #319

lpatiny opened this issue Apr 26, 2023 · 0 comments

Comments

@lpatiny
Copy link
Member

lpatiny commented Apr 26, 2023

subtract allows an Image and a Mask but in the code there is practically nothing common depending the kind of images.

export function subtract(
image: Image | Mask,
otherImage: Image | Mask,
options: SubtractImageOptions = {},

Should we not just split this method ? One for Image and one for Mask.

This could be part of the refactor:

#304

Should we in the folder operators split the one for Mask and the one for Image and have helpers if the code is common ?

@lpatiny lpatiny changed the title Create 2 methods for subtract Split subtract in 2 methods ? Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant