Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F32 Variant of Dynamic Image #1511

Closed
johannesvollmer opened this issue Jul 15, 2021 · 2 comments
Closed

F32 Variant of Dynamic Image #1511

johannesvollmer opened this issue Jul 15, 2021 · 2 comments

Comments

@johannesvollmer
Copy link
Contributor

Hi!

I just experimented a bit to find out what it takes to add f32 support to the dynamic image.

Unfortunately, there are two reasons that this cannot be implemented as a backwards-compatible change:

  1. Dynamic Image cannot derive Eq and Hash when it contains f32 values
  2. DynamicImage::grayscale(&self) cannot return ImageLuma32F as that does not exist yet.
    Possible breaking change: Return Result and fail for f32 images.

So far, I could not see any issues concerning the color space or color range of f32 images.
I will therefore continue experimenting, but this time branching off the next branch.
@johannesvollmer
Copy link
Contributor Author

Needs to wait until #1515 is done to get the existing basic F32 changes from the OpenEXR pull request.

@johannesvollmer johannesvollmer mentioned this issue Aug 1, 2021
Open
@johannesvollmer
Copy link
Contributor Author

PR was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johannesvollmer