Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laplacian from master is wrong #649

Closed
cospectrum opened this issue May 26, 2024 · 4 comments
Closed

Laplacian from master is wrong #649

cospectrum opened this issue May 26, 2024 · 4 comments

Comments

@cospectrum
Copy link
Contributor

Why it's [1, 1, 1, 1, -4, 1, 1, 1, 1], while in the doc it's [0, 1, 0, 1, -4, 1, 0, 1, 0]?
@cospectrum
Copy link
Contributor Author

cospectrum commented May 26, 2024 •
edited
Loading

We just have a bunch of laplacians now

@theotherphil
Copy link
Contributor

Looks like it was broken accidentally in #611 and there are no tests for laplacian_filter so this wasn’t caught.

Let’s add a test alongside fixing the kernel definition.

@cospectrum cospectrum mentioned this issue May 26, 2024
Merged
@theotherphil
Copy link
Contributor

The bug was added since the last release so no crate versions are impacted.

@theotherphil
Copy link
Contributor

Fixed by #650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theotherphil @cospectrum