Support SVG with only viewbox specified #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@netroy Looks like Travis failed due to NPM unavailability. |
|
@netroy what do you think about this issue? I need to fix it too. Maybe I can help? |
|
Any updates on this? |
|
@kyleolsondesign @ai I've emailed npm support to try to claim ownership of this package on npm, so we can get fixes like this rolled in. I'll keep you posted. |
|
I'll review the code according to my latest findings I've contributed to calipersjs/calipers#30, check the tests and merge it. |
borodean
added a commit
that referenced
this pull request
Nov 23, 2015
Support SVG with only viewbox specified
|
Improvements:
@zeke, can we release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When both
widthandheightare not specified,viewboxcould be a measure for the dimensions of an image.