Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content item for Person Observer Name in template Person Observer Identifying Attributes has wrong value type #76

Closed
hackermd opened this issue Jun 1, 2021 · 2 comments · Fixed by #75
Closed

Content item for Person Observer Name in template Person Observer Identifying Attributes has wrong value type #76

hackermd opened this issue Jun 1, 2021 · 2 comments · Fixed by #75
Assignees
@CPBridge
Labels
bug Something isn't working

Comments

@hackermd
Copy link
Collaborator

hackermd commented Jun 1, 2021 •
edited
Loading

I just realized that Person Observer Name is currently incorrectly encoded using TextContentItem instead of PnameContentItem (see highdicom.sr.templates.PersonObserverIdentifyingAttributes).
@hackermd hackermd added the bug Something isn't working label Jun 1, 2021
@CPBridge CPBridge mentioned this issue Jun 1, 2021
Merged
@fedorov
Copy link
Member

fedorov commented Jun 1, 2021

I came across this too, and thought that I am doing something incorrectly!

@CPBridge
Copy link
Collaborator

CPBridge commented Jun 1, 2021

Resolved in #75

@hackermd hackermd linked a pull request Jun 1, 2021 that will close this issue
Person Name Checks #75
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CPBridge CPBridge

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Person Name Checks ImagingDataCommons/highdicom
3 participants
@fedorov @hackermd @CPBridge