Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS image missing in the latest 2.1? #596

Closed
xuhdev opened this issue Jun 6, 2012 · 23 comments
Closed

RSS image missing in the latest 2.1? #596

xuhdev opened this issue Jun 6, 2012 · 23 comments

Comments

@xuhdev
Copy link

xuhdev commented Jun 6, 2012

After I upgraded yesterday, I found the RSS image at the rightup corner missing. See my page.

Does anyone know why?

@DarkSector
Copy link

It's there.

@xuhdev
Copy link
Author

xuhdev commented Jun 6, 2012

@DarkSector Really? I still cannot see it. I'm using Firefox 13.

@xuhdev
Copy link
Author

xuhdev commented Jun 6, 2012

The image is only available through chrome for me. When I tried with Firefox and Opera, it doesn't show.

@DarkSector
Copy link

Not visible using FF but visible using webkit based browsers. I think this is a browser bug.

@xuhdev
Copy link
Author

xuhdev commented Jun 6, 2012

Opera doesn't show, either. Haven't tested IE yet.

@DarkSector
Copy link

I wonder if others are experiencing the same issue.

@kenany
Copy link

kenany commented Jun 6, 2012

IE9

ie9

@imathis
Copy link
Owner

imathis commented Jun 6, 2012

@xuhdev I use Modernizr to test for mask image css capability. If it is there, you get the image, if not you get the text RSS. I updated Modernizr in 2.1 and their system had changed so I had to rewrite some css and make a change to Modernizr. It may work fine if you update.

Regarding IE9 I still have to test 2.1 in this browser.

@xuhdev
Copy link
Author

xuhdev commented Jun 6, 2012

@imathis
You mean what should I update?

@imathis
Copy link
Owner

imathis commented Jun 6, 2012

Based on this: http://caniuse.com/css-masks it looks lime image masks really only work in webkit right now. Perhaps the Modernizr test I've been using isn't working correctly anymore.

@imathis
Copy link
Owner

imathis commented Jun 6, 2012

@xuhdev Yes, update and it should work again on Webkit. I still need to make sure Modernizr isn't incorrectly saying other browsers are capable.

@xuhdev
Copy link
Author

xuhdev commented Jun 6, 2012

Perhaps we have a little misunderstanding here. My issue is not it doesn't work on webkit, but on other browsers. And I already have the latest version of octopress, I don't know what to update.

Thank you.

@imathis
Copy link
Owner

imathis commented Jun 6, 2012

Just in case it wasn't clear, I'm not using a colored image for the RSS icon, I'm using an alpha transparent png to create an image mask on a colored background. This way you can change your color scheme and the RSS icon will still look good.

It never worked in other browsers, it would show the text link 'RSS' instead. If you take a look at http://octopress.org it still does that. After looking at it further it's clear that Modernizr is mistakenly attempting to apply the image mask in browsers which don't support it, causing a colored box to replace the rss icon.

@xuhdev
Copy link
Author

xuhdev commented Jun 7, 2012

@imathis

I am very confused about what I should do. Please tell me what to update. The source, the style, or something others? I've already updated all of them to the latest version, but nothing changed: In firefox and Opera, the RSS is empty. Sorry to bother so much.

@kenany
Copy link

kenany commented Jun 7, 2012

After some testing, I found that the Modernizr test on http://octopress.org does indeed work, with Modernizr adding the no-maskImage class to the <html> tag. Because of this, the text "RSS" is correctly dispayed in IE9 and Firefox Nightly (the browsers I had available to test on) and the icon is shown in Chrome.

On your site @xuhdev, however, the class cssmask is being added instead.

@xuhdev
Copy link
Author

xuhdev commented Jun 7, 2012

@kenany But I compared the modernizr-2.0.js of the octopress.org site and mine, they are exactly the same file. They both have cssmask but no no-maskImage.

@xuhdev
Copy link
Author

xuhdev commented Jun 7, 2012

Seems http://octopress.org/javascripts/modernizr-2.0.js is using a different version from the latest source.

@kenany
Copy link

kenany commented Jun 7, 2012

The Modernizr build was updated in the 2.1 branch.

@xuhdev
Copy link
Author

xuhdev commented Jun 7, 2012

@kenany That's why this issue is here.

@imathis
Copy link
Owner

imathis commented Jun 7, 2012

I've fixed this locally, I'll be pushing an update soon.

@imathis imathis closed this as completed in 43850a2 Jun 7, 2012
imathis added a commit that referenced this issue Sep 6, 2012
… functions into a closure. Added Twitter and GitHub feeds to Octopress.js to reduce http requests. Fixes #596
@michaelsproul
Copy link

This seems to be broken again in Firefox 27...
broken image mask

@xuhdev
Copy link
Author

xuhdev commented Feb 12, 2014

@gnusouth I never see the image in Firefox. It should be text in Firefox.

@michaelsproul
Copy link

@xuhdev That sounds very odd to me. It's also hard to align the search box with both the image and the text (notice how in my image, it looks quite awkward).

Are there any downsides to just cramming an <img> tag inside the link? I just tried this and it works superbly. Plus it's simple and hackable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants