-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSS image missing in the latest 2.1? #596
Comments
It's there. |
@DarkSector Really? I still cannot see it. I'm using Firefox 13. |
The image is only available through chrome for me. When I tried with Firefox and Opera, it doesn't show. |
Not visible using FF but visible using webkit based browsers. I think this is a browser bug. |
Opera doesn't show, either. Haven't tested IE yet. |
I wonder if others are experiencing the same issue. |
@xuhdev I use Modernizr to test for mask image css capability. If it is there, you get the image, if not you get the text RSS. I updated Modernizr in 2.1 and their system had changed so I had to rewrite some css and make a change to Modernizr. It may work fine if you update. Regarding IE9 I still have to test 2.1 in this browser. |
@imathis |
Based on this: http://caniuse.com/css-masks it looks lime image masks really only work in webkit right now. Perhaps the Modernizr test I've been using isn't working correctly anymore. |
@xuhdev Yes, update and it should work again on Webkit. I still need to make sure Modernizr isn't incorrectly saying other browsers are capable. |
Perhaps we have a little misunderstanding here. My issue is not it doesn't work on webkit, but on other browsers. And I already have the latest version of octopress, I don't know what to update. Thank you. |
Just in case it wasn't clear, I'm not using a colored image for the RSS icon, I'm using an alpha transparent png to create an image mask on a colored background. This way you can change your color scheme and the RSS icon will still look good. It never worked in other browsers, it would show the text link 'RSS' instead. If you take a look at http://octopress.org it still does that. After looking at it further it's clear that Modernizr is mistakenly attempting to apply the image mask in browsers which don't support it, causing a colored box to replace the rss icon. |
I am very confused about what I should do. Please tell me what to update. The source, the style, or something others? I've already updated all of them to the latest version, but nothing changed: In firefox and Opera, the RSS is empty. Sorry to bother so much. |
After some testing, I found that the Modernizr test on http://octopress.org does indeed work, with Modernizr adding the On your site @xuhdev, however, the class |
@kenany But I compared the modernizr-2.0.js of the octopress.org site and mine, they are exactly the same file. They both have |
Seems http://octopress.org/javascripts/modernizr-2.0.js is using a different version from the latest source. |
The Modernizr build was updated in the 2.1 branch. |
@kenany That's why this issue is here. |
I've fixed this locally, I'll be pushing an update soon. |
… functions into a closure. Added Twitter and GitHub feeds to Octopress.js to reduce http requests. Fixes #596
@gnusouth I never see the image in Firefox. It should be text in Firefox. |
@xuhdev That sounds very odd to me. It's also hard to align the search box with both the image and the text (notice how in my image, it looks quite awkward). Are there any downsides to just cramming an |
After I upgraded yesterday, I found the RSS image at the rightup corner missing. See my page.
Does anyone know why?
The text was updated successfully, but these errors were encountered: