Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bye, Twitter Timeline #1101

Merged
merged 8 commits into from
Mar 9, 2013
Merged

Bye, Twitter Timeline #1101

merged 8 commits into from
Mar 9, 2013

Conversation

parkr
Copy link
Collaborator

@parkr parkr commented Mar 5, 2013

Code for #1100.

Does NOT contain docs changes.

@imathis
Copy link
Owner

imathis commented Mar 5, 2013

The follow button is the only thing missing now, but if people have the share button, adding a follow button is only a matter of adding this html wherever they want it.

<a href="//twitter.com/username" class="twitter-follow-button" data-show-count="true">Follow @username</a>

Since the necessary javascript is already there in _includes/twitter_sharing.html

  <script type="text/javascript">
    (function(){
      var twitterWidgets = document.createElement('script');
      twitterWidgets.type = 'text/javascript';
      twitterWidgets.async = true;
      twitterWidgets.src = '//platform.twitter.com/widgets.js';
      document.getElementsByTagName('head')[0].appendChild(twitterWidgets);
    })();
  </script>

@@ -4,7 +4,7 @@ Octopress is [Jekyll](https://github.com/mojombo/jekyll) blogging at its finest.

1. **Octopress sports a clean responsive theme** written in semantic HTML5, focused on readability and friendliness toward mobile devices.
2. **Code blogging is easy and beautiful.** Embed code (with [Solarized](http://ethanschoonover.com/solarized) styling) in your posts from gists, jsFiddle or from your filesystem.
3. **Third party integration is simple** with built-in support for Twitter, Pinboard, Delicious, GitHub Repositories, Disqus Comments and Google Analytics.
3. **Third party integration is simple** with built-in support for App.net, Pinboard, Delicious, GitHub Repositories, Disqus Comments and Google Analytics.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove mention of App.net as a built-in and we're good to merge.

imathis added a commit that referenced this pull request Mar 9, 2013
@imathis imathis merged commit 81ea4ae into 2.1 Mar 9, 2013
@imathis imathis deleted the bye-twitter branch March 9, 2013 23:05
@parkr
Copy link
Collaborator Author

parkr commented Mar 9, 2013

👊

@domenic
Copy link

domenic commented Jun 11, 2013

What happened? The issue referenced seems to have gone away. I was about to merge Octopress master into my blog but you guys removed the Twitter sidebar so...??

Also weird is that I cannot find these commits in https://github.com/imathis/octopress/commits/master (although they do show up in my local git history).

@parkr
Copy link
Collaborator Author

parkr commented Jun 11, 2013

@domenic We are unable to provide support for Twitter's v1.1 API due to developer restrictions they placed on API users. Once the v1.0 API is phased out (in the next couple months), your Twitter sidebar will cease working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants