Fix encoding issues in the loader #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somebee
previously approved these changes
Nov 14, 2019
aalemayhu
commented
Nov 14, 2019
aalemayhu
commented
Nov 14, 2019
loader.js
Outdated
| let pars = '?type=style'; | ||
|
|
||
| if(style.scoped){ | ||
| pars = pars + "&id=" + opts.id; | ||
| } | ||
| const query = `${src}!=!imba/loader?type=style&index=${i}&body=${body}!${remReq}${pars}` | ||
| cachedStyleBodies[styleBlockId] = style.content; | ||
| const query = `${src}!=!imba/loader?type=style&index=${i}&body=${styleBlockId}!${remReq}${pars}` |
aalemayhu
commented
Nov 14, 2019
aalemayhu
commented
Nov 14, 2019
aalemayhu
force-pushed
the
fix-encoding-issue-loader
branch
from
df82330
to
ce60c77
Compare
somebee
requested changes
Nov 19, 2019
The issues I have experienced were related to `encodeURIComponent` function not encoding `!` and `'`. Moving to caching the style bodies in a map resolves that since we no longer need to encode / decode. This also removes the wall of text generated from the webpack hack used to load the style. I added a comment in define to trigger the error during `yarn build`. Closes: #240 (Build issues with font-properties in SFC) Closes: #239 (Module not found: Error: Can't resolve 'important[...] in SFC)
aalemayhu
force-pushed
the
fix-encoding-issue-loader
branch
from
ce60c77
to
9f9601b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issues I have experienced were related to
encodeURIComponentfunction not encoding
!and'. Moving to cache the style bodies ina map resolves that since we no longer need to encode/decode.
This also removes the wall of text generated from the Webpack hack used
to load the style.
I added a comment in define to trigger the error during
yarn build.Purposed-by: Sindre Aarsaether sindre@identu.no
Closes: #240 (Build issues with font-properties in SFC)
Closes: #239 (Module not found: Error: Can't resolve 'important[...] in SFC)