fix: [1016] updated type definition of useForkRef with generic suppor… #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbhargav5
reviewed
Jun 30, 2022
imbhargav5
reviewed
Jun 30, 2022
| @@ -19,7 +19,10 @@ function setRef(ref: AnyRef, value: HTMLElementOrNull) { | |||
| * @param refA | |||
| * @param refB | |||
| */ | |||
| function useForkRef(refA: AnyRef, refB: AnyRef): CallbackRef | null { | |||
| function useForkRef<T extends HTMLElement | null = HTMLElementOrNull>( | |||
Codecov Report
@@ Coverage Diff @@
## main #1017 +/- ##
==========================================
- Coverage 91.13% 91.11% -0.02%
==========================================
Files 67 67
Lines 4028 4019 -9
Branches 665 664 -1
==========================================
- Hits 3671 3662 -9
Misses 356 356
Partials 1 1
Continue to review full report at Codecov.
|
imbhargav5
reviewed
Jun 30, 2022
|
🎉 This PR is included in version 5.11.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t and null support
Bug #1016