Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set limit to double jump #17

Closed
PorkLiquor opened this issue Aug 26, 2023 · 23 comments · Fixed by #18
Closed

Set limit to double jump #17

PorkLiquor opened this issue Aug 26, 2023 · 23 comments · Fixed by #18
Labels
enhancement New feature or request

Comments

@PorkLiquor
Copy link

Description
First of all, love this plugin, thanks so much for your contribution, tons of fun! One thing I'd really like is the ability to set a limit on the amount of double jumps as right now it is unlimited with no ability to prevent people from perma-flying.

Additional context
Would love an easy command to set dbl jump

@PorkLiquor PorkLiquor added the enhancement New feature or request label Aug 26, 2023
@imDMK
Copy link
Owner

imDMK commented Aug 26, 2023

Thank you for this suggestion.
An update will come out in a few days.
Pss... If you liked the plugin and want to support me, leave a star project.

@PorkLiquor
Copy link
Author

Thank you for this suggestion. An update will come out in a few days. Pss... If you liked the plugin and want to support me, leave a star project.

done, your plugin is king :)

@imDMK
Copy link
Owner

imDMK commented Aug 27, 2023

Your feature is ready.
But it needs testing to find bugs.
If you are willing to test this feature let me know.

@PorkLiquor
Copy link
Author

absolutely willing to test, want to share the file? will load it into my server ASAP

@imDMK
Copy link
Owner

imDMK commented Aug 27, 2023

DoubleJump.zip
Here you have compiled a jar file.
Don't test it on a public server with lots of players - it may be unstable.

@imDMK
Copy link
Owner

imDMK commented Aug 27, 2023

Report all your suggestions and any bugs you encounter.
Thanks for testing!
Regards.

@PorkLiquor
Copy link
Author

hey brother, installed the plugin and the commands are no longer appearing ingame verified it's installed via /plugins but the text is red

@imDMK
Copy link
Owner

imDMK commented Aug 27, 2023

What do you mean by commands are no longer appearing?
And what do you mean by text is red?
Could you attach screenshots?

Please make sure you have permission to use these commands.

On my localhost everything with commands is okay.

@PorkLiquor
Copy link
Author

I use apex hosting see attached images, apologies new to this! When I used the 'pre-loaded' one in the plugin library it worked but when i tried installing it myself no luck.

db4
db3
db2
db1

@imDMK
Copy link
Owner

imDMK commented Aug 27, 2023

Could you please show the error?
Error is available in the console.

@PorkLiquor
Copy link
Author

there is no error it is just not appearing in game at all, like i used to be able to type /doublejump for various commands and see nothing now

@imDMK
Copy link
Owner

imDMK commented Aug 27, 2023

The error appears when starting the plugin, in other words, when the server is loading.
When the name of the plugin is in red color, it means that it was not loaded correctly and must have thrown an error when trying to enable it.

@PorkLiquor
Copy link
Author

image
aha found the error see above

@PorkLiquor
Copy link
Author

running paper 1.20

@imDMK
Copy link
Owner

imDMK commented Aug 27, 2023

My mistake. Fixed here.
DoubleJump.zip

@PorkLiquor
Copy link
Author

working now! gonna mess around a bit and let you know ty <3

@imDMK
Copy link
Owner

imDMK commented Aug 29, 2023

Hey, did you manage to detect anything and how do you rate the new feature?

@PorkLiquor
Copy link
Author

works great and yes rated the new feature! the only thing i noticed is the double jump propels you forward vs a standard double jump which is fine

@imDMK
Copy link
Owner

imDMK commented Aug 30, 2023

I don't quite understand. What do you mean more? Can you record it somehow or something?
During my tests, I did not notice any change in the jumps.
Make sure the configuration hasn't changed.

@imDMK imDMK closed this as completed in #18 Aug 30, 2023
@PorkLiquor
Copy link
Author

Minecraft.2023-08-30.17-06-52.mp4

see how it sends you forward instead of jumping directly straight up?

@PorkLiquor
Copy link
Author

thanks again for all your help :)

@imDMK
Copy link
Owner

imDMK commented Aug 30, 2023

I think this is already done physics in Minecraft and probably won't do anything about it.
This feature has nothing to do with it because I didn't make any changes to the jumping physics, but I'll look into that.
Soon update with your feature and configuration improvement.
Thank you for your help!
Regards.

@PorkLiquor
Copy link
Author

no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants