Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist/Drift.js contains Drift.min.js content for release 1.3.0 #76

Closed
Zulcom opened this issue Aug 2, 2018 · 4 comments
Closed

dist/Drift.js contains Drift.min.js content for release 1.3.0 #76

Zulcom opened this issue Aug 2, 2018 · 4 comments

Comments

@Zulcom
Copy link

Zulcom commented Aug 2, 2018

Check out this files: dist/Drift.js and dist/Drift.min.js
As you can see in this diff, something went wrong and contributor @frederickfogerty
commit content of dist/Drift.min.js to dist/Drift.js

@frederickfogerty
Copy link
Contributor

frederickfogerty commented Aug 2, 2018

Hi @Zulcom are you experiencing any issues with the new dist/Drift.js file? If you are, can you please open a new issue. As we now use the Google Closure Compiler we don't have a method to compile the code without also minifying it, but we kept dist/Drift.js for backwards-compatibility.

@Zulcom
Copy link
Author

Zulcom commented Aug 3, 2018

No, i never have any issues with dist/Drift.js, but its very hard to debug when its minified.
It's not about perfomance or issues, it's about developer expirience and difficult to use your lib,
and i can deal with it.
So maybe you turn off source maps for minified file?

@frederickfogerty
Copy link
Contributor

Hey there @Zulcom unfortunately we aren't able to turn off minification for Drift.js. A sourcemap for both Drift.js and Drift.min.js already exists - it is Drift.min.js.map. Does this work for you?

@Zulcom
Copy link
Author

Zulcom commented Aug 8, 2018

It work form me, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants