You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a non-fully-qualified URL is passed, we're currently not doing any encoding on it (pending #8). This should probably be updated to at least be compliant with the "reserved" section of IETF RFC 3986. I'm going to dig into the best way to handle this. Hopefully URI.js has something helpful built-in, I just have to see if that's the case.
The text was updated successfully, but these errors were encountered:
Alrighty. So, I did a bit more digging on this. IETF RFC 3986 includes the following regular expression in Appendix B, "Parsing a URI Reference with a Regular Expression":
I tested it in Rubular with their test URL and our use case, and either%20or+ are acceptable in any part of the URL. From what I've been able to find, however, the + character is supposed to be interpreted as a literal plus sign when it comes before the query string, instead of a space.
Since we're using URI.js' URI.encodeReserved now anyway, I'm just going to close this issue.
When a non-fully-qualified URL is passed, we're currently not doing any encoding on it (pending #8). This should probably be updated to at least be compliant with the "reserved" section of IETF RFC 3986. I'm going to dig into the best way to handle this. Hopefully URI.js has something helpful built-in, I just have to see if that's the case.
The text was updated successfully, but these errors were encountered: