Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

Send notifications with gcm #70

Open
AdriVanHoudt opened this issue Sep 21, 2015 · 3 comments
Open

Send notifications with gcm #70

AdriVanHoudt opened this issue Sep 21, 2015 · 3 comments

Comments

@AdriVanHoudt
Copy link

See alexjlockwood/gcm#9
I will do a PR to both the gcm module and Incus to allow this option
AdriVanHoudt added a commit to AdriVanHoudt/incus that referenced this issue Sep 21, 2015
@AdriVanHoudt
allow notifications on gcm fixes Imgur#70
34f4b62
@AdriVanHoudt AdriVanHoudt mentioned this issue Sep 21, 2015
Closed
@alexjlockwood
Copy link

Hey guys,

Apparently a new Notification field was added for GCM messages. As mentioned above, I've gotten a request to update my GCM library with the new field: alexjlockwood/gcm#9

Just wanted to check in with you guys before I make any changes. I've never made a publicly-visible change to the library's API before and want to make sure adding the new field won't accidentally break you guys (or anyone else).

Alex

@AdriVanHoudt
Copy link
Author

I believe the tests are failing just because of that, does Go have a versioning system? You can release a major/breaking version (see semver) and people will need to activly update then

@AdriVanHoudt
Copy link
Author

@alexjlockwood I updated the PR a bit can you have a look?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow notifications on gcm fixes #70 AdriVanHoudt/incus
2 participants
@alexjlockwood @AdriVanHoudt