Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private repository support #23

Closed
univeous opened this issue Jun 22, 2023 · 3 comments · Fixed by #27
Closed

private repository support #23

univeous opened this issue Jun 22, 2023 · 3 comments · Fixed by #27

Comments

@univeous
Copy link
Contributor

Even if I configured GitHub credentials, I cannot use this plugin to manage private repositories.
logs:

cmdline_args: ["install", "debug"]
Plug start
Installation config loaded
Plug: { "name": "*****", "url": "https://git::@github.com/*****/*****.git", "plug_dir": "res://.plugged/*****", "include": [], "exclude": [], "branch": "", "tag": "", "commit": "", "dev": false, "on_updated": "", "install_root": "" }
Installing...
Request quit declined, threadpool is still running
Execute task <SceneTree#24830280835>.install_plugin()
Installing plugin *****...
Downloading ***** from https://git::@github.com/*****/*****.git...
Cloning from https://git::@github.com/*****/*****.git to C:/*****...
Execute "cd "C:/*****" && git clone --depth=1 --progress "https://git::@github.com/*****/*****.git" "C:/*****" 2> nul"
Execution ended(code:128): [""]
Failed to clone from https://git::@github.com/*****/*****.git
Failed to download *****
Failed to install plugin ***** with error code 128
Execution finished <SceneTree#24830280835>.install_plugin()
All thread finished

If I run git clone directly in cmd, there is no problem.

@imjp94
Copy link
Owner

imjp94 commented Jun 22, 2023

Confirmed, gd-plug can't install private repository

@NathanLovato
Copy link
Contributor

Actually, it does support private repositories, but you need to use the full Git SSH path instead of nickname/repository. For example, for our repository godot-practice-framework, you'd have to use git@github.com:GDQuest/godot-practice-framework.git

This allows git to use your SSH keys to access the repository:

extends "res://addons/gd-plug/plug.gd"

func _plugging():
    plug("git@github.com:GDQuest/godot-practice-framework.git")

I'll PR a suggestion to the README

@imjp94
Copy link
Owner

imjp94 commented Sep 11, 2023

Wow, that's cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants